Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 362496 - [quick assist][nls tooling] IAE in new 'Create field...' quick assist in properties editor
Summary: [quick assist][nls tooling] IAE in new 'Create field...' quick assist in prop...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.8   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.8 M4   Edit
Assignee: Deepak Azad CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-31 10:48 EDT by Deepak Azad CLA
Modified: 2011-12-06 06:50 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Deepak Azad CLA 2011-10-31 10:48:00 EDT 
If a property is not a valid java identifier the following exception is thrown on invoking the quick assist. 

java.lang.IllegalArgumentException
	at org.eclipse.jdt.core.dom.SimpleName.setIdentifier(SimpleName.java:198)
	at org.eclipse.jdt.core.dom.AST.newSimpleName(AST.java:2031)
	at org.eclipse.jdt.internal.corext.refactoring.nls.AccessorClassModifier.getNewFinalStringFieldDeclaration(AccessorClassModifier.java:331)
	at org.eclipse.jdt.internal.corext.refactoring.nls.AccessorClassModifier.addKey(AccessorClassModifier.java:291)
	at org.eclipse.jdt.internal.corext.refactoring.nls.AccessorClassModifier.addKey(AccessorClassModifier.java:282)
	at org.eclipse.jdt.internal.corext.refactoring.nls.AccessorClassModifier.addFields(AccessorClassModifier.java:191)
	at org.eclipse.jdt.internal.ui.propertiesfileeditor.PropertiesQuickAssistProcessor.getCreateFieldsInAccessorClassProposals(PropertiesQuickAssistProcessor.java:188)
	at org.eclipse.jdt.internal.ui.propertiesfileeditor.PropertiesQuickAssistProcessor.collectAssists(PropertiesQuickAssistProcessor.java:87)
	at org.eclipse.jdt.internal.ui.propertiesfileeditor.PropertiesCorrectionProcessor.computeQuickAssistProposals(PropertiesCorrectionProcessor.java:8
Comment 1 Deepak Azad CLA 2011-10-31 10:53:07 EDT 
Fixed in master - 02dab19d88de7da80ad7430db6057ec8f7d3e5f1

Now the quick assist simply ignores such properties.
Comment 2 Raksha Vasisht CLA 2011-12-06 06:50:51 EST 
Verified for Juno M4 with 4.2 I20111205-1810.