Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 362474 - NavigationHistoryService: Bookmark.getText() is different from values in Bookmark.getPath()
Summary: NavigationHistoryService: Bookmark.getText() is different from values in Book...
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Scout (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Andreas Hoegger CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-31 07:54 EDT by Adrian Moser CLA
Modified: 2021-08-19 11:25 EDT (History)
2 users (show)

See Also:
zimmermann: indigo+
zimmermann: juno+

Attachments
Proposed patch. (1.23 KB, patch)
2011-10-31 07:55 EDT, Adrian Moser CLA 		Andreas.Hoegger: iplog+
Andreas.Hoegger: review+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Moser CLA 2011-10-31 07:54:37 EDT 
Build Identifier: M20110210-1200

The NavigationHistoryService creates a bookmark for each step in Navigation history. Currently, the navigation step bookmark is created before a search is executed. The created bookmark does contain the correct path and search data, but the display text refers to one step before the current step.

Solution: Create the navigation bookmark after the search is executed. 

No migration for existing scout projects necessary.

Reproducible: Always

Steps to Reproduce:
1. Perform a search with search text 'A'
2. Perform a search with search text 'B'
3. The navigation bookmark created for step 2 will contain search text 'B', but it's display text value referes to text 'A'.
Comment 1 Adrian Moser CLA 2011-10-31 07:55:09 EDT 
Created attachment 206204 [details]
Proposed patch.
Comment 2 Andreas Hoegger CLA 2011-10-31 08:18:40 EDT 
Patch applied; Thank you Adrian.
Comment 3 Matthias Zimmermann CLA 2012-02-29 07:03:23 EST 
shipped with eclipse scout 3.7.2 (indigo sr2)