Community
Participate
Working Groups
By EGL convention, a function name begins with "is" if the function returns a Boolean to indicate a status. However, eglx.persistence.sql.SQLResultSet uses the Java names for rowDeleted and rowUpdated. For clarity and consistency, please change the EGL names to isRowDeleted and isRowUpdated.
This is SQL language support, I changed the components to Language and subscribed Joe.
If this is our intended convention in EGL, then I agree with this change, but how many other functions should have 'is' in front of them and do not follow this convention?
(In reply to comment #2) > If this is our intended convention in EGL, then I agree with this change, but > how many other functions should have 'is' in front of them and do not follow > this convention? Booleans often begin with a verb: eglx.lang.Stereotypes, eglx.lang.String, eglx.persistence.ScrollableDataSource, eglx.persistence.sql.Column, eglx.persistence.sql.SQLDataSource, eglx.ui.rui.ExternalTypes org.eclipse.edt.eunit.runtime.LogResult but not always: eglx.persistence.sql.JoinColumn eglx.services.OneWay eglx.xml.binding.annotation.XMLArray eglx.xml.binding.annotation.XMLAttribute eglx.xml.binding.annotation.XMLElement eglx.xml.binding.annotation.XMLArrayXMLRootElement eglx.ui.rui.ExternalTypes (in both lists) The names of rowDeleted and rowUpdated seem particularly unclear, although the original assertion about "is" as a universal is not correct.
I talked with Tim about this, and he claims the 'rowDeleted' and 'rowUpdated' methods are defined in a well known standard and should be left this way.
closed
