Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 362423 - Screen space waste
Summary: Screen space waste
Status: CLOSED DUPLICATE of bug 420238
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: All All
: P3 major with 8 votes (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact: Bogdan Gheorghe CLA
URL:
Whiteboard:
Keywords:
Depends on: 421122
Blocks:
  Show dependency tree
 
Reported: 2011-10-30 05:24 EDT by Andrey Loskutov CLA
Modified: 2013-11-05 17:16 EST (History)
10 users (show)

See Also:


Attachments
Screenshot of 3.7 window with no e4 (ok) (35.70 KB, image/png)
2011-10-30 05:25 EDT, Andrey Loskutov CLA
no flags Details
Screenshot of 4.2 window with e4 (bad) (42.76 KB, image/png)
2011-10-30 05:26 EDT, Andrey Loskutov CLA
no flags Details
Screenshot depicting the behaviour in question. (4.46 KB, image/png)
2011-10-31 14:23 EDT, Remy Suen CLA
no flags Details
4.2 "Classic" theme on Ubuntu 11.04 with Gnome desktop (bad) (37.23 KB, image/png)
2011-10-31 14:56 EDT, Andrey Loskutov CLA
no flags Details
3.7 with 4.2 side by side (minimize/close buttons) (4.08 KB, image/png)
2011-10-31 15:17 EDT, Andrey Loskutov CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Loskutov CLA 2011-10-30 05:24:11 EDT
Build Identifier: Build id: I20111028-1100

AS IS:
Since e4 there are many places where UI is not efficiently uses space:

1) place between views/editor stacks is wider as before and "eats" 10 pixel (and looks unprofessional). 
2) 3 pixel too much between main toolbar and editor area
3) 3 pixel too much between view/editor area and its borders
4) view/editor minimize/maximize buttons are way to huge

TO BE:
Either add a preference to disable the "fancy" rounded UI with wasted space or provide a *default* theme where the space is used as efficient as in 3.7.
TO BE:
Either make this configurable or revert it back to the "usual" 2-3 pixel

Reproducible: Always
Comment 1 Andrey Loskutov CLA 2011-10-30 05:25:07 EDT
Created attachment 206176 [details]
Screenshot of 3.7 window with no e4 (ok)
Comment 2 Andrey Loskutov CLA 2011-10-30 05:26:10 EDT
Created attachment 206177 [details]
Screenshot of 4.2 window with e4 (bad)

Attached two screenshots showing same Eclipse window size on 3.7 and 4.2 e4.
Comment 3 Remy Suen CLA 2011-10-31 13:46:46 EDT
(In reply to comment #0)
> Either add a preference to disable the "fancy" rounded UI with wasted space or
> provide a *default* theme where the space is used as efficient as in 3.7.

In the 'Appearance' preference page you can switch to the 'Classic' theme.
Comment 4 Thomas Schindl CLA 2011-10-31 13:54:18 EDT
... and just to add that we are going to provide direct customization support in 4.2. See http://ericoneclipse.blogspot.com/2011/10/eclipse-4-beyond-compatibility.html which shows the CSS-Editor in action
Comment 5 Thomas Schindl CLA 2011-10-31 13:59:00 EDT
and one more note you very likely have to restart so that the padding changes take place because they are not dynamically applied IIRC.
Comment 6 Andrey Loskutov CLA 2011-10-31 14:08:01 EDT
(In reply to comment #3)
> (In reply to comment #0)
> > Either add a preference to disable the "fancy" rounded UI with wasted space or
> > provide a *default* theme where the space is used as efficient as in 3.7.
> 
> In the 'Appearance' preference page you can switch to the 'Classic' theme.

First, why Eclipse set such not usable theme default one?
Additionally, even after restarting Eclipse (another issue: nobody told me that I need it, earlier there was a dialog) issue 4) is still there.

So there is the updated list
1-3) solved by Classic theme
4) View/editor minimize/maximize buttons are way to huge
5) There is no dialog showing me that I have to reboot to apply all settings
6) Classic theme is not default OR unusable theme is default

(In reply to comment #4)
> ... and just to add that we are going to provide direct customization support
> in 4.2. See
> http://ericoneclipse.blogspot.com/2011/10/eclipse-4-beyond-compatibility.html
> which shows the CSS-Editor in action

I guess no one of my colleagues will like to customize new workspaces each time. Some create new workspaces each week. Come on, default theme must be professionally made. Eclipse should not repeat same mistakes like Canonical with Unity.
Comment 7 Thomas Schindl CLA 2011-10-31 14:22:46 EDT
(In reply to comment #6)
> (In reply to comment #3)
> > (In reply to comment #0)
> > > Either add a preference to disable the "fancy" rounded UI with wasted space or
> > > provide a *default* theme where the space is used as efficient as in 3.7.
> > 
> > In the 'Appearance' preference page you can switch to the 'Classic' theme.
> 
> First, why Eclipse set such not usable theme default one?
> Additionally, even after restarting Eclipse (another issue: nobody told me that
> I need it, earlier there was a dialog) issue 4) is still there.
> 
> So there is the updated list
> 1-3) solved by Classic theme
> 4) View/editor minimize/maximize buttons are way to huge
> 5) There is no dialog showing me that I have to reboot to apply all settings

I think this is a problem of the our rendering engine which uses the css-padding and sets the value on the SWT-Layout but for safety reason this might be a good idea.
Comment 8 Remy Suen CLA 2011-10-31 14:23:09 EDT
Created attachment 206233 [details]
Screenshot depicting the behaviour in question.

(In reply to comment #6)
> 4) View/editor minimize/maximize buttons are way to huge

I think this is an artifact of the part's title using a large font for you. It looks okay for me on Windows.

> 5) There is no dialog showing me that I have to reboot to apply all settings

Opened bug 362522 for this.
Comment 9 Andrey Loskutov CLA 2011-10-31 14:29:38 EDT
(In reply to comment #8)
> > 4) View/editor minimize/maximize buttons are way to huge
> 
> I think this is an artifact of the part's title using a large font for you. It
> looks okay for me on Windows.

So must be Linux (or at least non-Windows) specific, as 3.7 has not such big icons on same desktop for me.

> > 5) There is no dialog showing me that I have to reboot to apply all settings
> 
> Opened bug 362522 for this.

Thanks.
Comment 10 Andrey Loskutov CLA 2011-10-31 14:32:34 EDT
(In reply to comment #9)
> (In reply to comment #8)
> > > 4) View/editor minimize/maximize buttons are way to huge
> > 
> > I think this is an artifact of the part's title using a large font for you. It
> > looks okay for me on Windows.
> 
> So must be Linux (or at least non-Windows) specific, as 3.7 has not such big
> icons on same desktop for me.

Hold on, your Windows? screenshot shows a lot more padding around minimize/close icons as usual, at least in my opinion. I can't compare it right now, could you check it on the same workstation and 3.7?

And on Linux, not the icons are huge, but the surrounding space, so it must be platform neutral.
Comment 11 Remy Suen CLA 2011-10-31 14:42:46 EDT
(In reply to comment #10)
> Hold on, your Windows? screenshot shows a lot more padding around
> minimize/close icons as usual, at least in my opinion.

If you mean the padding, then yes, there's more padding now. However, the problem ultimately goes away if you switch to the 'Classic' theme. You may still notice a slight difference since they are actual tool items now (instead of custom drawn in 3.x).
Comment 12 Andrey Loskutov CLA 2011-10-31 14:56:06 EDT
Created attachment 206234 [details]
4.2 "Classic" theme on Ubuntu 11.04 with Gnome desktop (bad)

(In reply to comment #11)
> If you mean the padding, then yes, there's more padding now. However, the
> problem ultimately goes away if you switch to the 'Classic' theme.

It does not, at least not on Linux (Ubuntu 11.04 64 bit, Gnome desktop, see screenshot). Compare the new screenshot with the first one (3.7).

> You may
> still notice a slight difference since they are actual tool items now (instead
> of custom drawn in 3.x).

This could be the root cause for the regression.
Comment 13 Remy Suen CLA 2011-10-31 15:00:09 EDT
(In reply to comment #12)
> > You may
> > still notice a slight difference since they are actual tool items now (instead
> > of custom drawn in 3.x).
> 
> This could be the root cause for the regression.

In terms of physical pixel height they are identical. Unless your concern is a) the horizontal pixel width and/or b) that they are more centered as opposed to be aligned to the top right.
Comment 14 Andrey Loskutov CLA 2011-10-31 15:17:02 EDT
Created attachment 206237 [details]
3.7 with 4.2 side by side (minimize/close buttons)

(In reply to comment #13)
> In terms of physical pixel height they are identical. Unless your concern is a)
> the horizontal pixel width
Yes.
Comment 15 Remy Suen CLA 2011-11-17 11:21:02 EST
(In reply to comment #14)
> (In reply to comment #13)
> > In terms of physical pixel height they are identical. Unless your concern is a)
> > the horizontal pixel width
> Yes.

Not sure if there's anything to be done here since the intent was to make those buttons real items instead of being custom drawn.
Comment 16 Lars Vogel CLA 2013-11-05 17:02:42 EST
(In reply to Andrey Loskutov from comment #0)
> Build Identifier: Build id: I20111028-1100
> 
> AS IS:
> Since e4 there are many places where UI is not efficiently uses space:
> 
> 1) place between views/editor stacks is wider as before and "eats" 10 pixel
> (and looks unprofessional). 
> 2) 3 pixel too much between main toolbar and editor area
> 3) 3 pixel too much between view/editor area and its borders
> 4) view/editor minimize/maximize buttons are way to huge

Thanks Andrey. Could you open a separate bug for 4.) as this requires a fix in the MinMaxAddon. For the reduction of whitespace I have a suggested patch in Bug 420238, I therefore mark this one as duplicate.

*** This bug has been marked as a duplicate of bug 420238 ***
Comment 17 Andrey Loskutov CLA 2013-11-05 17:16:28 EST
(In reply to Lars Vogel from comment #16)

> Thanks Andrey. Could you open a separate bug for 4.) as this requires a fix
> in the MinMaxAddon. 
bug 421122