Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 362366 - Code is always being generated for VE but shouldn't
Summary: Code is always being generated for VE but shouldn't
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Huo Zhen Zhong CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-28 16:14 EDT by Justin Spadea CLA
Modified: 2017-02-23 14:16 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Spadea CLA 2011-10-28 16:14:23 EDT 
The JSDev generator is adding "egl.setWidgetLocation()" calls in the code, but this should only happen when generating for the design page. You should change it to pass some parameter to the generator and check for that parameter instead of always generating it.
Comment 1 Tony Chen CLA 2011-10-30 23:04:05 EDT 
Is this the same behavior as in RBD?
Comment 2 Huo Zhen Zhong CLA 2011-10-31 04:13:38 EDT 
Hi, Justin
It works as in RBD, I think it is reasonable. Think about one scenario, if we generate different code for design tab and preview tab, when user switch from one tab to another, we need to regenerate the code, that will make VE slow. So I think that's why in RBD, the egl.setWidgetLocation() is always generated.
Comment 3 Justin Spadea CLA 2011-10-31 10:04:21 EDT 
That function is NOT always generated in RBD. It is only generated for the VE and not for the file written to disk (which is used by debug). When the VE is generating JS on the fly, it should pass some parameter to the generator that indicates "enable egl.setWidgetLocation() generation".
Comment 4 Huo Zhen Zhong CLA 2011-11-01 01:46:18 EDT 
It has indirectly fixed by 358855, in which the egl.setWidgetLocation() will only been generated in the temp file.
Comment 5 Justin Spadea CLA 2011-11-04 14:40:43 EDT 
Verified