Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 362293 - Unsetting value in some cases can cause to fail IntegrityChecker
Summary: Unsetting value in some cases can cause to fail IntegrityChecker
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.core (show other bugs)
Version: 4.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Eike Stepper CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-28 07:14 EDT by Egidijus Vaisnora CLA
Modified: 2020-12-11 10:36 EST (History)
0 users

See Also:

Attachments
Test and patch v1 (6.51 KB, patch)
2011-10-28 07:37 EDT, Egidijus Vaisnora CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Egidijus Vaisnora CLA 2011-10-28 07:14:06 EDT 
Integrity checker doesn't take into account CDOID.NULL in processing Unset revision delta.
Comment 1 Egidijus Vaisnora CLA 2011-10-28 07:37:06 EDT 
Created attachment 206124 [details]
Test and patch v1

Actually probelem is caused by the fact that CDO has two values to show object absence. One is Java null and another is CDOID.NULL. Therefore revision compare produces optional unset delta and  on this optional delta integrity checker stucks. Patch provides fix for IntegrityCheck.
BTW, I recall that it is not the first issue I am fixing, which is related to CDOID.NULL. Why do we have *two* types of NULL? I think it is root problem and it will continue to cause new issues in future.
Comment 2 Eike Stepper CLA 2012-08-14 22:52:17 EDT 
Moving all open issues to 4.2. Open bugs can be ported to 4.1 maintenance after they've been fixed in master.
Comment 3 Eike Stepper CLA 2013-06-29 12:18:12 EDT 
We'll try to address open problems in 4.3 (master) first and then port fixes back to 4.2.
Comment 4 Eike Stepper CLA 2015-07-14 02:12:13 EDT 
Moving all open bugzillas to 4.5.
Comment 5 Eike Stepper CLA 2016-07-31 00:54:47 EDT 
Moving all unaddressed bugzillas to 4.6.
Comment 6 Eike Stepper CLA 2017-12-28 01:17:47 EST 
Moving all open bugs to 4.7
Comment 7 Eike Stepper CLA 2018-04-23 07:25:31 EDT 
The test case is committed to master:
http://git.eclipse.org/c/cdo/cdo.git/commit/?id=70a093e34a380de2a2c24d8fdfb68f6adef8034a

The fix wasn't needed anymore, probably due to the fixes for bug 533909, bug 405543, or bug 438682.
Comment 8 Eike Stepper CLA 2020-12-11 10:27:34 EST 
Closing.
Comment 9 Eike Stepper CLA 2020-12-11 10:36:11 EST 
Closing.