Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 362230 - Enable the CSS editor to run in a Preference Page
Summary: Enable the CSS editor to run in a Preference Page
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 4.2 M3   Edit
Assignee: Eric Moffatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-27 14:25 EDT by Eric Moffatt CLA
Modified: 2011-11-02 15:05 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Moffatt CLA 2011-10-27 14:25:51 EDT 
The static method 'getRenderedPlaceholders' currently just returns the value returned from the 'get' call on the map.

The StackRenderer *expects* that this list is non-null. This was discovered by work that Bogdan was doing to host a CSS editor in a preference page.
Comment 1 Eric Moffatt CLA 2011-10-27 14:32:46 EDT 
Pushed in >20111027.

commit 1792e7d9e7090ca15dd51e090ddffcb3367a334c
Comment 2 Eric Moffatt CLA 2011-10-27 15:30:34 EDT 
We've found another fix that's necessary to get the CSS editor going; it needs to be able to access the IEditorPart in order to call 'doSave'...

Changed the title to reflect that there is more than one fix required to get the CSS editor going in the pref page...
Comment 3 Eric Moffatt CLA 2011-10-27 15:34:49 EDT 
Pushed in >20111027.

commit 518f6bd4231ad5496e9a9068408d6355fb4293dd

This just adds the IEditorPart into the MPart's context in 'createPartControl' (CompatibilityView also adds the IViewPart for consistenct).

Paul, you aren't around or I'd have checked if this one is OK. If you want to change this just let me know...