Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 362200 - Failures in OTTypeHierarchyTests
Summary: Failures in OTTypeHierarchyTests
Status: VERIFIED FIXED
Alias: None
Product: Objectteams
Classification: Tools
Component: OTDT (show other bugs)
Version: 2.0   Edit
Hardware: Other Linux
: P3 normal (vote)
Target Milestone: 2.1 M3   Edit
Assignee: Stephan Herrmann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-27 10:12 EDT by Stephan Herrmann CLA
Modified: 2013-01-15 16:42 EST (History)
0 users

See Also:

Attachments
fix (792 bytes, patch)
2011-10-27 10:16 EDT, Stephan Herrmann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2011-10-27 10:12:16 EDT 
In a recent build we had failures in these tests:

org.eclipse.objectteams.otdt.tests.superhierarchy.OTSuperTypeHierarchyTest001.testGetAllSuperclasses_T8R2_phantomMode

org.eclipse.objectteams.otdt.tests.superhierarchy.OTSuperTypeHierarchyTest001.testGetAllSuperclasses_T7R3_phantomMode

org.eclipse.objectteams.otdt.tests.superhierarchy.OTSuperTypeHierarchyTest001.testGetAllSuperclasses_T7R2_phantomMode

org.eclipse.objectteams.otdt.tests.superhierarchy.OTSuperTypeHierarchyTest001.testGetAllSuperclasses_T4R2_phantomMode

org.eclipse.objectteams.otdt.tests.superhierarchy.OTSuperTypeHierarchyTest001.testLinearizationR2

org.eclipse.objectteams.otdt.tests.superhierarchy.OTSuperTypeHierarchyTest006.testGetAllSuperclasses_T3R2_phantomMode

When investigating when this was introduced I wasn't even able to reproduce
a clean test run using a recent release version, so I assume that the failures
depend on some implicit processing-order issue?
Comment 1 Stephan Herrmann CLA 2011-10-27 10:16:24 EDT 
Created attachment 206073 [details]
fix

This check in HierarchyResolver was too narrow, thus no OTType was
registered for phantom role T7.R1.

Inspecting the file history showed that this change was introduced way back
during the migration to Eclipse 3.2 to accommodate changed processing
order in 3.2, but the condition in question was not further documented.
Comment 2 Stephan Herrmann CLA 2011-10-27 10:19:33 EDT 
Released for 2.1 M3 (r2074).
Comment 3 Stephan Herrmann CLA 2012-01-17 13:22:26 EST 
The fix has been backported to 2.0.2 via commit 8ad00e64e1caa6f90336b7a9594f5694c29ac893
Comment 4 Stephan Herrmann CLA 2012-09-22 15:59:11 EDT 
Tests are green, considering as fixed indeed.