Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 362195 - [Utils] ICatalogManager#setCatalogSet
Summary: [Utils] ICatalogManager#setCatalogSet
Status: NEW
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EMF-Facet (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P5 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-27 09:48 EDT by Nicolas Bros CLA
Modified: 2020-05-01 11:26 EDT (History)
1 user (show)

See Also:
gdupe: juno+
gdupe: kepler+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Bros CLA 2011-10-27 09:48:37 EDT 
The method setCatalogSet in the interface ICatalogManager feels backwards: it is called setCatalogSet, but it in fact does not set the CatalogSet but adds the catalog to the list of catalogs in the CatalogSet.

I think this method should be replaced by:
ICatalogManager#getCatalogSet(), that would return the org.eclipse.emf.facet.util.emf.catalog.Catalog managed by the ICatalogManager. And the ICatalogSetManager which owns and is responsible for its CatalogSet should also be responsible for adding the catalogs to its CatalogSet.
Comment 1 Nicolas Bros CLA 2011-10-27 10:08:58 EDT 
(In reply to comment #0)
> I think this method should be replaced by:
> ICatalogManager#getCatalogSet()
I meant:
ICatalogManager#getCatalog()