362184 – NPE in BookmarkUtility, Bookmark handling for custom columns

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 362184 - NPE in BookmarkUtility, Bookmark handling for custom columns

Summary: NPE in BookmarkUtility, Bookmark handling for custom columns

Status:	CLOSED FIXED

Alias:	None

Product:	z_Archived
Classification:	Eclipse Foundation
Component:	Scout (show other bugs)
Version:	unspecified
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	---
Assignee:	Project Inbox
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2011-10-27 07:57 EDT by Adrian Moser
Modified:	2021-08-19 11:09 EDT (History)
CC List:	1 user (show)

See Also:

Flags:	zimmermann: juno+

Attachments
Proposed patch. (7.23 KB, patch) 2011-10-27 07:58 EDT, Adrian Moser	stephan.leichtvogt: iplog+	Details \| Diff
Bugfix Patch (817 bytes, patch) 2011-11-09 07:21 EST, Adrian Moser	stephan.leichtvogt: iplog+	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Adrian Moser

2011-10-27 07:57:38 EDT

Build Identifier: M20110210-1200

- in table pages without ITableCustomizer, 
  the BookmarkUtility.bmLoadTablePage/bmStoreTablePage may throw a NPE
- opening a bookmark, custom columns are not correctly rebuilt
  to fix this issue, a call to removeAllColumns without UI interaction 
  is required
- ITableCustomizer.removeColumn/removeAllColumns: 
  a confirm dialog should be shown, in case the method is called from a menu,
  otherwise no UI interaction is needed
- Reset all columns does not remove custom columns

Reproducible: Always

Steps to Reproduce:
1. Open/Create a bookmark on a table without ITableCustomizer
2. You may get a NPE
3. Existing custom columns may not be removed and replaced by the bookmark

Comment 1 Adrian Moser

2011-10-27 07:58:04 EDT

Created attachment 206068 [details]
Proposed patch.

Comment 2 Stephan Leicht Vogt

2011-10-27 08:08:12 EDT

Comment on attachment 206068 [details]
Proposed patch.

Please create patches in future with workspace as root.

Comment 3 Stephan Leicht Vogt

2011-10-27 08:09:50 EDT

Thanks for the patch. I reviewed and applied it to trunk for Eclipse 3.8

Comment 4 Adrian Moser

2011-11-09 07:21:11 EST

Created attachment 206680 [details]
Bugfix Patch

This ticket introduced a bug:
- create a table page without search, but with ITableCustomizer
- load some data
- create a bookmark and reload it immediately (e.g. to force a table refresh)
=> the table data will not reload

Reason:
- the introduced ITable.resetColumnConfiguration() does remove all rows,
  since there are potentially new custom columns on the table customizer
- now we have to force a table reload to refresh the table

Bugfix forcing reload of table data.

Comment 5 Adrian Moser

2011-11-09 07:22:01 EST

Ticket reopened due to last comment.

Comment 6 Stephan Leicht Vogt

2011-11-14 10:47:04 EST

Thanks for the second patch. I reviewed and applied it to trunk for Eclipse 3.8

Comment 7 Matthias Zimmermann

2012-07-09 06:50:37 EDT

ticket closed.
deliverd as part of eclipse scout 3.8.0 (juno release train)