Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 362128 - Need checking to indicate what browsers can be used by the VE
Summary: Need checking to indicate what browsers can be used by the VE
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P1 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Yun Feng Ma CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-26 16:08 EDT by Brian Svihovec CLA
Modified: 2017-02-23 14:16 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Svihovec CLA 2011-10-26 16:08:35 EDT
For example, if a user opens the preference page and selects XULRunner, without having XULRunner installed, they should not be allowed to close the preference page with the current selection.
Comment 1 Lisa Lasher CLA 2011-10-26 17:32:22 EDT
changing to Enhancement
Comment 2 Will Smythe CLA 2011-10-26 21:36:26 EDT
In a ST to Jimmy a few days ago, I suggested the following design for the preferences page (wording TBD):

[ x ] Use default rendering engine
  [ o ] WebKit (Chrome and Safari)
  [ o ] Mozilla (Firefox)
  [ o ] Trident (Internet Explorer)

By default, the checkbox would be checked (this will cause the radio buttons to be disabled). This preference would tell the VE to 'auto-detect' the browser engine to use the first time the VE is started. Once the VE picked a browser, only changing the preference or restarting the workbench would result in a different engine being used.

The radio options are enabled only if the checkbox is unchecked and also depending on the OS and/or any other 'easy' checks that can be made to detect whether a rendering engine will work in the user's environment.

In general, I am not a big fan of preventing users from exiting preference pages. For this reason and to avoid adding additional logic to into the preference page, I vote we allow the user to make any choice they want and then let the VE tell the user if the selected browser is not supported (like we do today).
Comment 3 Yun Feng Ma CLA 2011-10-27 23:30:46 EDT
The fix has been in cvs.

Now in Eclipse 3.7, the preference page looks like:
  [ x ] Default
  [ o ] WebKit 
  [ o ] XULRunner
  [ o ] Internet Explorer

In Eclipse 3.6, the preference page looks like:
  [ x ] Default
  [ o ] XULRunner
  [ o ] Internet Explorer

Please give me the properly words for these preference. Thanks.
Comment 4 Brian Svihovec CLA 2011-11-05 15:41:18 EDT
I would like to propose that we adopt Will's layout in comment 2, and then when default is selected, we disable all of the children and mark the current default as selected.  

On more than one occasion I have had to do some diagnosis of a users machine to see which browser they were running (i.e. asking them what version of Eclipse they were using, did they have Safari installed, etc).

This additional change should be prioritized low on our list of things to do for .7, and I am fine with it waiting for 1.0.
Comment 5 Yun Feng Ma CLA 2011-11-09 21:26:17 EST
I've opened enhancement 363414 for Will's layout, targeting 1.0. Closing this one. Thanks.
Comment 6 Brian Svihovec CLA 2011-12-14 08:59:07 EST
Verified and closed.