Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 362119 - Always perform a dry run before "Push to Upstream"
Summary: Always perform a dry run before "Push to Upstream"
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 1.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-26 13:50 EDT by Markus Keller CLA
Modified: 2012-06-26 05:46 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2011-10-26 13:50:24 EDT 
Add a preference to always perform a dry run before actually executing a "Push to Upstream" operation.

"Push to Upstream" is currently a black box operation. I think the dry run should be the default, with a "Don't show this dialog again" checkbox.

I know I can use Team > Remote > Configure Push to Upstream... to get the preview, but that's quite far away.
Comment 1 Markus Keller CLA 2011-11-15 09:35:14 EST 
(In reply to comment #0)
> I know I can use Team > Remote > Configure Push to Upstream... to get the
> preview, but that's quite far away.

I think that's not even true, see bug 363468.

So this is really a bug. It must be possible to know what's going to happen on Push. Otherwise, horrible things like bug 361707 are more likely to happen.

The preview is also important since Git has quite a steep learning curve, and especially new users cannot always tell what's going on behind the scenes (e.g. will Push push all branches or just the current one? Will it push tags?, etc.)
Comment 2 Stephan Herrmann CLA 2012-02-05 12:03:09 EST 
+1

Are you suggesting this for all push operations or just "Push to Upstream"?

Currently, I'd feel safest if such an option would apply to all pushes, no matter which workflow I used.
Comment 3 Markus Keller CLA 2012-06-26 05:46:22 EDT 
It should apply to all operations that modify a remote repository.

The Push... dialog already offers a dry-run if you click "Next >" on the "Push Ref Specification" page. The preference could enforce this by graying out the "Finish" button on that page (or by making "Next >" the default button).