Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 362114 - LibraryInstallPanel triggers SWTException
Summary: LibraryInstallPanel triggers SWTException
Status: RESOLVED FIXED
Alias: None
Product: WTP Common Tools
Classification: WebTools
Component: Faceted Project Framework (show other bugs)
Version: 3.3.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.6.3   Edit
Assignee: Roberto Sanchez Herrera CLA
QA Contact: Konstantin Komissarchik CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-26 13:44 EDT by Brian Vosburgh CLA
Modified: 2015-01-14 13:12 EST (History)
2 users (show)

See Also:
konstantin: review+

Attachments
stacktrace (2.83 KB, text/plain)
2011-10-26 13:44 EDT, Brian Vosburgh CLA 		no flags Details
proposed patch (1.08 KB, patch)
2012-05-15 11:41 EDT, Brian Vosburgh CLA 		shr31223: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Vosburgh CLA 2011-10-26 13:44:00 EDT 
Created attachment 206010 [details]
stacktrace

The method LibraryInstallPanel.handleOperationConfigChanged(...) dispatches itself to the UI thread but does not check whether the widget is disposed once it is there. The result is the attached exception stacktrace. This occurs if the LibraryInstallPanel is closed before the dispatched runnable is executed on the UI thread.
Comment 1 Brian Vosburgh CLA 2012-05-15 11:41:57 EDT 
Created attachment 215654 [details]
proposed patch

Add simple dispose check.
Comment 2 Roberto Sanchez Herrera CLA 2015-01-14 13:12:36 EST 
Committed to master for WTP 3.6.3 and 3.7.
I also increased the version of the plugin and feature

http://git.eclipse.org/c/webtools-common/webtools.common.fproj.git/commit/?id=294553e79d8ab8193bd0fa9e29aebb9ca62322aa