Community
Participate
Working Groups
Build Identifier: SashForm's children are not rendered properly if SashForm's parent is a Form with text. Reproducible: Always Steps to Reproduce: Reproduce with the following steps: 1. Apply the following snippets: @Override public void createPartControl(Composite parent) { Form form = toolkit.createForm(parent); //form.setText("Form"); form.getBody().setLayout(GridLayoutFactory.fillDefaults().extendedMargins(8, 8, 8, 5).create()); form.getBody().setLayoutData(GridDataFactory.fillDefaults().grab(true, true).create()); ScrolledPageBook pageBook = toolkit.createPageBook(form.getBody(), SWT.NONE); pageBook.setLayoutData(GridDataFactory.fillDefaults().grab(true, true).create()); Composite page = pageBook.createPage("firstPage"); page.setLayout(GridLayoutFactory.fillDefaults().create()); SashForm sash = new SashForm(page, SWT.HORIZONTAL); sash.setLayoutData(GridDataFactory.fillDefaults().grab(true, true).create()); sash.setSashWidth(5); Composite client = toolkit.createComposite(sash, SWT.BORDER); client.setLayout(GridLayoutFactory.fillDefaults().spacing(SWT.DEFAULT, 10).extendedMargins(3, 0, 0, 10).create()); client.setLayoutData(GridDataFactory.fillDefaults().grab(true, true).create()); SashForm sash2 = new SashForm(sash, SWT.VERTICAL); sash2.setLayoutData(GridDataFactory.fillDefaults().grab(true, true).create()); sash2.setSashWidth(5); client = toolkit.createComposite(sash2, SWT.BORDER); client.setLayout(GridLayoutFactory.fillDefaults().spacing(1, 1).extendedMargins(3, 0, 0, 10).create()); client.setLayoutData(GridDataFactory.fillDefaults().grab(true, true).create()); client = toolkit.createComposite(sash2, SWT.BORDER); client.setLayout(GridLayoutFactory.fillDefaults().spacing(1, 1).extendedMargins(3, 3, 0, 10).create()); client.setLayoutData(GridDataFactory.fillDefaults().grab(true, true).create()); sash2.setWeights(new int[] {40, 50}); sash.setWeights(new int[]{30, 70}); pageBook.showPage("firstPage"); } 2. Now unremove code to set Form's text. 3. See that the SashForm's children is missing their bottom border. The above snippets works in RCP.
Created attachment 206007 [details] Form Without Text in RAP
Created attachment 206008 [details] Form With Text in RAP
Created attachment 206009 [details] Form With Text in RCP
I mean 'unremark' on step 2
Setya, which version of RAP are you using? Could this be related to text size determination? Does browser reload fixes the problem?
Ivan, I'm using 1.4.0-M5. The bug is actually reproducible in Eclipse internal browses, but when I tried in Chrome & Firefox recentlyjj it worked OK. But you're right, in the internal browser reloading it fixes the problem. But I have another snippet in which the bug is reproducible under Chrome & Firefox which I'll submit as soon as it ready. Regards, Setya
Setya, in 1.4 release and later in current development 1.5 stream (CVS HEAD) we did a lot of text size determination improvements. Could you try your code with 1.4 SR1 or latest nightly build?
Ivan, At least I can confirm that the bug is still there in 1.4.0, but so far I haven't switched to 1.4.0 yet since some of my unit tests throws error: Javascript error occurred: TypeError: Result of expression 'this._rows' [null] is not an object. But this is another case I guess. I'll report here with the test result in another version. Regards, Setya
Ivan, The bug still exists in 1.4.1 We have problem using 1.5.0 target since there're some incompatibilities. Regards, Setya
As I can't reproduce it with current CVS HEAD and both internal and external (Firefox, IE) browsers, I'll be waiting for your snippet.
Ivan, Do I need to open separate bug ? as I don't think it's caused by Form's header text, but by TableViewer having too many rows. As for the above snippet, did you try it with Eclipse's internal browser? Regards, Setya
(In reply to comment #11) > Do I need to open separate bug ? as I don't think it's caused by Form's header > text, but by TableViewer having too many rows. If you think that this bug related to Form header is invalid, please close it as such. For a different issue with TableViewer please open a separate bug. > As for the above snippet, did you try it with Eclipse's internal browser? Yes... I'm. But please note that I tested it with current CVS HEAD after the bug 270397 (standard rendering in IE) has been fixed. Maybe this is related.
> If you think that this bug related to Form header is invalid, please close it > as such. For a different issue with TableViewer please open a separate bug. OK > > As for the above snippet, did you try it with Eclipse's internal browser? > Yes... I'm. But please note that I tested it with current CVS HEAD after the > bug 270397 (standard rendering in IE) has been fixed. Maybe this is related. I tried under 1.4.1 on Linux. Regards, Setya
