Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 362054 - Unmarking elements as reviewed not preserved
Summary: Unmarking elements as reviewed not preserved
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 0.9   Edit
Assignee: Sebastien Dubois CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-26 07:40 EDT by Alvaro Sanchez-Leon CLA
Modified: 2012-02-17 18:00 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alvaro Sanchez-Leon CLA 2011-10-26 07:40:35 EDT
To reproduce:

* Have to commit reviews items
* Mark both items as user reviewed
* Unmark them both
* close and open review
* The items are back to user reviewed
Comment 1 Sebastien Dubois CLA 2012-01-06 15:46:37 EST
This reason why this happens is because when a review item is marked as reviewed all children are also marked.  However, when the review item is unmarked, the children are not.  So, when the review is closed and re-opened, since all the children of the review item are still makred as reviewed, the parent review item is also marked as reviewed.  We need to discuss how to handle the reviewed mark on parent and children.
Comment 2 Sebastien Dubois CLA 2012-02-17 18:00:28 EST
This is now fixed, as removing the mark on the parent recursively removes it from all the children
Comment 3 Sebastien Dubois CLA 2012-02-17 18:00:42 EST
see comment above