Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 362052 - "Show Annotations" should also work on history items
Summary: "Show Annotations" should also work on history items
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 1.2   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: 2.0   Edit
Assignee: Kevin Sawicki CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-26 07:12 EDT by Markus Keller CLA
Modified: 2012-06-11 20:01 EDT (History)
7 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2011-10-26 07:12:00 EDT
"Show Annotations" should also work on history items. Currently, I can show blame annotations on the workspace version of the file, but I can't do this on an older version of the file.

This was supported by the Eclipse CVS client.
Comment 1 Markus Keller CLA 2011-11-14 05:40:12 EST
This bug makes it impossible to see past commits that changed the whole file (e.g. formatting changes or the SWT commit 093c579a4ffd9551acb901bba9617e7aa776989d that restored accidentally deleted files).
Comment 2 Kevin Sawicki CLA 2011-11-15 14:10:08 EST
Proposed fix pushed to: http://egit.eclipse.org/r/#change,4622
Comment 3 Stefan Lay CLA 2011-11-30 07:56:28 EST
Commit 8a524f1f0802b045f8ad84b01df710002ed5fb76 adds the feature to the file table in the history view as well as the to file section of the commit editor.

What's still missing is a menu entry to the context menu in the editor of historic versions. Normally I first open an editor and then I decide to open the blame annotations. Unfortunately there is no Team menu on editors which do not have an IFile as input.
Comment 4 Stephan Herrmann CLA 2012-02-04 06:34:43 EST
(In reply to comment #3)
> Commit 8a524f1f0802b045f8ad84b01df710002ed5fb76 adds the feature to the file
> table in the history view as well as the to file section of the commit editor.

Thanks heaps, that's an important feature. Unfortunately, without this bug report I didn't ever find how to invoke this command.

I was actually looking for something in the context menu of a commit while the history is narrowed down to the file I'm interested in. Could that please be added, too? In that mode we already have several "Open" commands, so it seems the context menu knows that a single file is selected.
Comment 5 Markus Keller CLA 2012-02-16 12:23:34 EST
> I was actually looking for something in the context menu of a commit while the
> history is narrowed down to the file I'm interested in. Could that please be
> added, too? In that mode we already have several "Open" commands, so it seems
> the context menu knows that a single file is selected.

+1
Comment 6 Kevin Sawicki CLA 2012-02-16 12:28:22 EST
Just to clarify, which menu are you referring to where you want the action to be available?

The context menu of the Files section in the commit editor? Or somewhere else?
Comment 7 Markus Keller CLA 2012-02-16 12:56:48 EST
(In reply to comment #6)
> The context menu of the Files section in the commit editor? Or somewhere else?

Nope, I already see "Show Annotations" there (as well as in the files section of the History view).

Stefan (comment 3) wants it in the context menu of an editor of an old revision, e.g. an editor opened via "Open in Editor" in the Files section.

Stephan (comment 4) and I want it in the context menu of a commit in the main table of the History view. If the History view's input is a single file, that context menu already contains "Compare with Working Tree", "Open", and "Open in Text Editor". If a commit affects a large number of files, it's too much work to find the input file in the files section of the History view.
Comment 8 Kevin Sawicki CLA 2012-02-16 12:58:15 EST
Great, thanks for the clarification.
Comment 9 Kevin Sawicki CLA 2012-02-16 17:22:52 EST
Proposed fix to add 'Show Annotations' menu to history table when scoped to single file pushed here: https://git.eclipse.org/r/#/c/5110/
Comment 10 Matthias Sohn CLA 2012-06-11 20:01:48 EDT
merged as f1e40cf062f90590862543f47dd71d76627d59ce