Community
Participate
Working Groups
Build Identifier: Bug following the discussion here: http://www.eclipse.org/forums/index.php/t/210744/ * Naming consistency: clearDeletedRows() => discardAllDeletedRows() * Add the possibility to discard a specific deleted row discardDeleteRow(TableRow deletedRow) discardDeleteRows(TableRow deletedRow) discarding a DeletedRow by index (or array of indexes) makes no sense, because if the row is deleted, the row do not have an index anymore. Reproducible: Always
Created attachment 208888 [details] Patch for bug 361985 Patch that implements the proposed modifications. new methods: - discardAllDeletedRows(); - discardDeletedRow(ITableRow deletedRow); - discardDeletedRows(ITableRow[] deletedRows); deprecated: - clearDeletedRows() [use discardAllDeletedRows() instead] MIGRATION: ITable#clearDeletedRows() is deprecated, use ITable#discardAllDeletedRows() instead. How can I test this modification (and write a test) to ensure that the methods work as expected ?
Created attachment 209033 [details] Patch for bug 361985 (v2) Patch for bug 361985. Version 2. Fix a NPE: call setTableInternal(null) after getRowKeys(row)
Created attachment 209034 [details] Test for Bug 361985 Test for this bug. To run this class with JUnit, a test infrastructure as described in [1] is needed. This is not a plain JUnit test, because the Scout Runtime/Equinox need to be started. [1] http://www.eclipse.org/forums/index.php/mv/msg/262115/757087/#msg_757087
Patch slightly modified and applied on trunk for Juno. Thank you Jeremie.
ticket closed. deliverd as part of eclipse scout 3.8.0 (juno release train)