Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 361955 - [Compatibility] Resetting perspective to an empty perspective closes the perspective
Summary: [Compatibility] Resetting perspective to an empty perspective closes the pers...
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.1   Edit
Hardware: PC All
: P3 normal with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-25 12:13 EDT by Sarah CLA
Modified: 2019-11-14 03:51 EST (History)
3 users (show)

See Also:


Attachments
Patch that checks if container is MPerspective before setting toBeRendered (1.15 KB, patch)
2011-10-25 12:15 EDT, Sarah CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sarah CLA 2011-10-25 12:13:40 EDT
Build Identifier: 

If I save an empty perspective, when I call workbenchPage.resetPerspective(), the perspective is closed due to the lack of children (much like in bug 356252 [1]).  

I've created a patch (with a fix similar to that for the bug mentioned above) that fixes the problem for my application.  This is very similar to the bug I mentioned above, so if you'd prefer we can close this one and reopen the other.


[1]http://bugs.eclipse.org/bugs/show_bug.cgi?id=356252

Reproducible: Always

Steps to Reproduce:
1. Create and save an empty perspective
2. Call reset perspective
3. The perspective is closed
Comment 1 Sarah CLA 2011-10-25 12:15:45 EDT
Created attachment 205930 [details]
Patch that checks if container is MPerspective before setting toBeRendered
Comment 2 Sarah CLA 2011-10-25 12:21:26 EDT
Eclipse Build Info: 
Version: 4.1.0
Build id: I20110620-1631
Comment 3 Eric Moffatt CLA 2011-10-25 15:14:39 EDT
Sarah, thanks a lot for the patch ! I *think* I've already addressed this while doing the fix for bug 356252, does your issue still occur on recent builds (i.e. after the 'fix' for 356252 went in) ?
Comment 4 Sarah CLA 2011-10-25 17:25:29 EDT
(In reply to comment #3)
> Sarah, thanks a lot for the patch ! I *think* I've already addressed this while
> doing the fix for bug 356252, does your issue still occur on recent builds
> (i.e. after the 'fix' for 356252 went in) ?

I used the latest version from the R4_development branch of [1] and was still able to see the issue.  Looking at the change you committed [2], it looks like you changed the renderingChangeHandler, while the patch I submitted made pretty much the same change to childrenHandler.

[1] http://git.eclipse.org/gitroot/platform/eclipse.platform.ui.git
[2] http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R4_development&id=d49acf4e4a216ba93d0f21bf08f09cef5ef84dbd
Comment 5 Lars Vogel CLA 2019-11-14 03:51:18 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

If the bug is still relevant, please remove the "stalebug" whiteboard tag.