Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 361947 - Boolean arguments are not checked for valid state
Summary: Boolean arguments are not checked for valid state
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: Debug (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M3   Edit
Assignee: Michael Rennie CLA
QA Contact: Michael Rennie CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 367806
  Show dependency tree
 
Reported: 2011-10-25 11:39 EDT by Hernan Pepe Petersen CLA
Modified: 2012-01-03 19:45 EST (History)
1 user (show)

See Also:

Attachments
Proposed fix (1.09 KB, patch)
2011-10-25 11:41 EDT, Hernan Pepe Petersen CLA 		no flags Details | Diff
updated patch (1.71 KB, patch)
2011-10-26 12:54 EDT, Michael Rennie CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hernan Pepe Petersen CLA 2011-10-25 11:39:52 EDT 
Build Identifier: 20110615-0604

When you add your own Boolean Argument to the Debug configuration tab and define the isValid() method as false Debug button does not disable.

Reproducible: Always

Steps to Reproduce:
1.Addd a Boolean argument to the Configuration arguments and define isValid() as return false;
2. Go to a new debug configuration.
3. Enable or disable and check the Debug button.
Comment 1 Hernan Pepe Petersen CLA 2011-10-25 11:41:11 EDT 
Created attachment 205928 [details]
Proposed fix

This is the fix i've used for this to work. Thanks, Hernan.
Comment 2 Michael Rennie CLA 2011-10-26 12:54:59 EDT 
Created attachment 206004 [details]
updated patch

It makes sense to call isValid for all of the types of arguments we support for launching connectors, as such I updated the original patch to include IntegerArgument and SelectedArgument (as well as BooleanArgument)
Comment 3 Michael Rennie CLA 2011-10-26 12:58:16 EDT 
Applied second patch to HEAD