Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 361903 - jetty-all-server MANIFEST contains wrong import: org.apache.jasper;version="[7.5,8}"
Summary: jetty-all-server MANIFEST contains wrong import: org.apache.jasper;version="[...
Status: RESOLVED FIXED
Alias: None
Product: Jetty
Classification: RT
Component: osgi (show other bugs)
Version: 7.5.2   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 7.5.x   Edit
Assignee: Jan Bartel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-25 06:26 EDT by Dmytro Pishchukhin CLA
Modified: 2012-03-14 17:41 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dmytro Pishchukhin CLA 2011-10-25 06:26:38 EDT
Build Identifier: 7.5.2, 7.5.3, 7.5.4

jetty-all-server MANIFEST contains wrong import: org.apache.jasper;version="[7.5,8}"

Reproducible: Always
Comment 1 Hugues Malphettes CLA 2011-10-25 06:34:44 EDT
This is a regression introduced when we upgraded to the latest jsp-impl-2.1
We ended up re-distributing ourselves the classes missing from jasper-glassfish build.
We need to force BND to export the version 2.1 for those packages.
Comment 2 Hugues Malphettes CLA 2011-10-26 08:37:02 EDT
Ok fixing the version export is easy. but the problem remains.

The problem is that the aggregate contains classes that should have been inside the jsp-impl jar itself: the glassfish build of jsp-impl does not contain the ECJ compiler and instead rely on the java-compiler JSR99 inside jdk6... which absolutely does not work in OSGi.

To workaround the lack of JDK5 support Jan stuffed the missing classes in the jetty-jsp-21 bundle and made it an osgi fragment.
We don't use it in the p2-osgi build. Instead we made sure that the orbit build does contain the classes that the glassfish build does not have.

Unfortunately the jetty-all-server does contain jetty-jsp-2.1 which pretty much prevents it from working in OSGi: in OSGi, the jetty-jsp-2.1 needs to be a fragment to the jsp-impl bundle. It can't be part of jetty's aggregate bundle

At this point I think we have 2 choices:
- convince Jan to remove jetty-jsp-2.1 from the aggregate so that it has a chance to work in OSGi.
- make a new aggregate specifically for OSGi.

Jan, Dmytro; comments welcome.
Comment 3 Dmytro Pishchukhin CLA 2011-10-26 09:00:56 EDT
Is it possible to make jetty-jsp-2.1 as a fragment for jetty-all-server to enable JSP support? 

in this case jetty-all-server bundle will not contain JSP functionality by default. If user wants to add JSP support he adds jetty-osgi-boot-jsp and jetty-jsp-2.1 bundles.
Comment 4 Jan Bartel CLA 2012-03-14 02:45:25 EDT
Dmytro,

I've checked the most recent jetty-all-server manifest (jetty-7.6.2), and the org.apache.jasper import no longer exists.

Can you confirm that this issue can be closed?

thanks
Jan
Comment 5 Dmytro Pishchukhin CLA 2012-03-14 06:48:27 EDT
Hello Jan,

I've tested with 7.6.2. It works.

Dmytro

(In reply to comment #4)
> Dmytro,
> 
> I've checked the most recent jetty-all-server manifest (jetty-7.6.2), and the
> org.apache.jasper import no longer exists.
> 
> Can you confirm that this issue can be closed?
> 
> thanks
> Jan
Comment 6 Jan Bartel CLA 2012-03-14 17:41:58 EDT
Fixed for 7.6.2/8.1.2