Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 361902 - [DialogUtil]: #open(Dialog, DialogCallback) - Allow null as second parameter
Summary: [DialogUtil]: #open(Dialog, DialogCallback) - Allow null as second parameter
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.5 M3   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-25 05:33 EDT by Frank Appel CLA
Modified: 2011-10-25 06:04 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frank Appel CLA 2011-10-25 05:33:21 EDT 
DialogUtil#open(Dialog, DialogCallback) does not allow null as DialogCallback parameter. This seems to me a little harsh. There are a lot of cases where the dialog is only used as info box. In such cases there is no need for evaluation of the return value. The current implementation enforces to add an empty DialogCallback implementation just to be conform with the parameter check.
Comment 1 Rüdiger Herrmann CLA 2011-10-25 06:04:06 EDT 
Removed the null-check for the DialogCallback argument and changed JavaDoc accordingly.
Changes are in CVS HEAD.