Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 361770 - Use WebKit as VE browser
Summary: Use WebKit as VE browser
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P1 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Yun Feng Ma CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-24 01:33 EDT by Tony Chen CLA
Modified: 2017-02-23 14:17 EST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chen CLA 2011-10-24 01:33:34 EDT
WebKit plug-ins is available with Eclipse 3.7. We need to do some experiment to make VE use WebKit, and see how performance is with WebKit.
Comment 1 Tony Chen CLA 2011-10-24 01:40:57 EDT
I believe there are two questions to answer here. 

1. Can VE be switched to use Webkit. I won't expect too much issues here if Webkit is a supported browser type for SWT. 

2. Can our RUI application be run on Webkit. I'm not aware any testing with Webkit so far, so I suppose we need to do a full testing for Webkit browser, and probably will have something to 'fix'. 

This bug, however, focus on the 1st question only.
Comment 2 Lisa Lasher CLA 2011-10-24 17:58:13 EDT
I think we should be cautious about adding something that requires Eclipse 3.7, as that will prevent shell sharing with RBD.  It's ok if we have a feature that is available only if you are on Eclipse 3.7, but we can't make our main path require 3.7.  

RBD will not move up Eclipse levels until 2013 at the earliest, possibly 2014, depending on when RAD ships their next release after 8.5
Comment 3 Will Smythe CLA 2011-10-24 22:43:03 EDT
I agree with maintaining support for both Eclipse 3.6 and 3.7, but we definitely can't default to IE on Windows (we got away from IE for very good reasons in RBD 801). We should only use IE if XULRunner and WebKit are not properly configured.

WebKit is the rendering engine for Safari and Chrome - browsers we already support. In my 'hack job' test with WebKit, the VE worked just fine. 

In my note on 10/24, I made this statement:
I would list all 3 browser/engine options in the preferences, but disable the ones that are not supported in the user's environment (based on Eclipse level, operating system, and installed software). I would default to Webkit, if possible, then XULRunner, and then IE (in that order).
Comment 4 Tony Chen CLA 2011-10-25 02:31:52 EDT
To know which browser is available, we may simply to a test instead of checking for the preconditions, trying to create instance for each of them (for webkit, check Eclipse version first), those can be created successfully are available browsers.  

Something more to consider:

1. We need to have a matrix to test all the reasonable combination of OS, Eclipse 3.6/3.7 and installation of render engine. 

2. The FAQ mentioned below known issue, seems not a common situation, but should also be considered. 
--http://www.eclipse.org/swt/faq.php#howusewebkit---
It is important to note that conflicts have been reported between the dependent libraries of WebKit and Mozilla. As a result it is advised that Browser instances with these respective types not be mixed in an application. If a Browser with one of these types must be used in an application then java property org.eclipse.swt.browser.DefaultType should also be set to this type to ensure that SWT.NONE-style Browsers do not cause the libraries from the other native browser renderer to be loaded (see How do I specify the default type of native renderer that is used by the Browser?).
--

3. We have different logic for different browser when setting browser URL, see EvPreviewBrowserManager.setBrowserUrl(), may need to review if this works with Webkit.
Comment 5 Will Smythe CLA 2011-10-26 23:13:18 EDT
There were a *lot* of the following lines in my Console view after launching a new workbench with WEBKIT hard-coded as the default VE browser. I am not sure if the WebKit browser was the cause, or if the problem was due to something else ..

__getevent : terminated
__getevent : terminated
__getevent : terminated
__getevent : terminated
__getevent : terminated
__getevent : terminated
__getevent : terminated
__getevent : terminated
Comment 6 Yun Feng Ma CLA 2011-10-27 23:33:25 EDT
The change is in now. Please try it and give your feedback. Thanks.
Comment 7 Yun Feng Ma CLA 2011-11-07 20:33:23 EST
All changes are in. Resolving this. Thanks.
Comment 8 Lisa Lasher CLA 2011-11-09 14:04:14 EST
Closing this work item