Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 361752 - Add new console bundles to RCP feature
Summary: Add new console bundles to RCP feature
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 3.8   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 3.8 M3   Edit
Assignee: Kim Moir CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-23 08:04 EDT by Thomas Watson CLA
Modified: 2011-10-25 19:04 EDT (History)
4 users (show)

See Also:

Attachments
patch (2.58 KB, patch)
2011-10-24 11:35 EDT, Kim Moir CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Watson CLA 2011-10-23 08:04:51 EDT 
The following bundles should be added to the RCP feature and its source feature:

org.eclipse.equinox.console
org.apache.felix.gogo.command
org.apache.felix.gogo.runtime
org.apache.felix.gogo.shell

org.eclipse.equinox.console.source
org.apache.felix.gogo.command.source
org.apache.felix.gogo.runtime.source
org.apache.felix.gogo.shell.source
Comment 1 Kim Moir CLA 2011-10-23 16:50:47 EDT 
Is this for M3 or M4?
Comment 2 Thomas Watson CLA 2011-10-23 18:15:08 EDT 
I would like to include this in M3 if possible.
Comment 3 Kim Moir CLA 2011-10-24 11:35:37 EDT 
Created attachment 205836 [details]
patch
Comment 5 Thomas Watson CLA 2011-10-25 13:49:06 EDT 
(In reply to comment #4)
> Released for I20111025-1325
> 
> http://git.eclipse.org/c/platform/eclipse.platform.releng.maps.git/commit/?id=980b0a5d7ce74ef0eb559146c2afd09b0f884255

That commit does not seem to include the changes to the feature.xml you posted in attachment 205836 [details].
Comment 6 Thomas Watson CLA 2011-10-25 13:58:27 EDT 
(In reply to comment #5)
> (In reply to comment #4)
> > Released for I20111025-1325
> > 
> > http://git.eclipse.org/c/platform/eclipse.platform.releng.maps.git/commit/?id=980b0a5d7ce74ef0eb559146c2afd09b0f884255
> 
> That commit does not seem to include the changes to the feature.xml you posted
> in attachment 205836 [details].

Sorry for the noise, of coarse the commit doesn't have the changes.  The feature is still in CVS:

http://dev.eclipse.org/viewsvn/viewvc.cgi/org.eclipse.sdk-feature/features/org.eclipse.rcp/feature.xml?view=markup

Thanks Kim.
Comment 7 Kim Moir CLA 2011-10-25 14:05:55 EDT 
Yes, the project is still in CVS, have to move them after eclipsecon. Last group to move...
Comment 8 Kim Moir CLA 2011-10-25 19:04:51 EDT 
Fixed.