Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 361656 - Staging View does not react on selection in Repositories View
Summary: Staging View does not react on selection in Repositories View
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 1.2   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 major (vote)
Target Milestone: 0.12-M1   Edit
Assignee: Jens Baumgart CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 361692 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-10-21 10:05 EDT by Jens Baumgart CLA
Modified: 2011-10-22 07:21 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jens Baumgart CLA 2011-10-21 10:05:12 EDT 
The problem occurs sice commit dd932dbc9b886afad13b3cd22fed3832d9fcbda6
Comment 1 Remy Suen CLA 2011-10-21 10:13:44 EDT 
Is it because of the added getAdapter(Class) to RepositoryTreeNode? That also introduced bug 361556.

Though to be fair, that code path was problematic since c7e8d63066b26a8c08b10c219b806a5313b1e529.
Comment 2 Jens Baumgart CLA 2011-10-21 11:02:12 EDT 
(In reply to comment #1)
> Is it because of the added getAdapter(Class) to RepositoryTreeNode? That also
> introduced bug 361556.
> 
> Though to be fair, that code path was problematic since
> c7e8d63066b26a8c08b10c219b806a5313b1e529.

Yes. But the real problem seems to be in StagingView.reactOnSelection.
I'l fix this now.
Comment 3 Jens Baumgart CLA 2011-10-21 11:35:42 EDT 
Fix proposed: http://egit.eclipse.org/r/4388
Comment 4 Remy Suen CLA 2011-10-21 13:31:13 EDT 
*** Bug 361692 has been marked as a duplicate of this bug. ***
Comment 5 Remy Suen CLA 2011-10-22 07:21:34 EDT 
(In reply to comment #3)
> Fix proposed: http://egit.eclipse.org/r/4388

The change has been merged into master. Thanks, Jens.