Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 361561 - [Compatibility] Lots of separators in the global debug toolbar
Summary: [Compatibility] Lots of separators in the global debug toolbar
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.2 M4   Edit
Assignee: Remy Suen CLA
QA Contact: Paul Webster CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-20 11:29 EDT by Remy Suen CLA
Modified: 2011-12-06 13:34 EST (History)
1 user (show)

See Also:


Attachments
ToolBar rendering patch v1 (1.55 KB, patch)
2011-10-20 13:50 EDT, Remy Suen CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2011-10-20 11:29:09 EDT
We have an excessive amount of separators in the global debug toolbar for stepping actions when compared against 3.x.
Comment 1 Remy Suen CLA 2011-10-20 13:50:48 EDT
Created attachment 205667 [details]
ToolBar rendering patch v1

We could use the same kind of separator rendering code that we use for menus. Not sure if this is what we want to do or not though.
Comment 2 Remy Suen CLA 2011-11-18 11:25:03 EST
Paul, please advise on comment 1.
Comment 3 Paul Webster CLA 2011-11-18 11:28:28 EST
Sure, go ahead, give that a whirl :-)

PW
Comment 4 Remy Suen CLA 2011-11-30 15:31:01 EST
(In reply to comment #1)
> Created attachment 205667 [details]
> ToolBar rendering patch v1

Fix released to master.
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=17fe3a2c50a57b30b1284ecfdf2a05808477625c
Comment 5 Remy Suen CLA 2011-12-06 13:34:45 EST
Verified with I20111205-2330 on Windows 7.