Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 361484 - git status hiccupped, let me commit twice
Summary: git status hiccupped, let me commit twice
Status: RESOLVED WORKSFORME
Alias: None
Product: Orion
Classification: ECD
Component: Git (show other bugs)
Version: 0.3   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: libing wang CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 339848
Blocks:
  Show dependency tree
 
Reported: 2011-10-19 18:56 EDT by Susan McCourt CLA
Modified: 2015-04-27 11:00 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2011-10-19 18:56:16 EDT 
I've seen this once before, I think, but definitely saw it today.
Latest code on orion.eclipse.org

I was committing a change to a local topic branch.  I pasted the bug number in the commit text and pushed "commit."  I got a progress message and then no update at all, so I wasn't sure it worked.  So I tried hitting commit again.  Same thing, progress message, no update on the page.  So I opened the log and saw two commits, a minute apart.  The first commit has the change, the second commit has no change at all.  

You can see the commits involved in case this matters, as I pushed them to a remote branch.

branch is origin/bug361481

This commit is the real one:
5595c5765292d098d2cf6a598872a73bef56f787

this is the empty one
d057e35606ce3d6947f24c3b4baced4bf073eba8
Comment 1 Tomasz Zarna CLA 2011-10-20 09:50:41 EDT 
This could have been spotted if we had bug 339848 fixed. For now, we could disable the Commit button until result of a previous commit has returned. A warning about an empty commit would also help.
Comment 2 libing wang CLA 2011-10-20 10:11:34 EDT 
(In reply to comment #1)
> This could have been spotted if we had bug 339848 fixed. For now, we could
> disable the Commit button until result of a previous commit has returned. A
> warning about an empty commit would also help.

Yes. The current logic to disable commit button is complicated (e.g. comment 4 at Bug 355735). We can disable commit button right away after it is clicked but I there is no way to bring it back unless you refresh.
Without solving the issue at the first place, everything else is just temporary. The best workaround I would recommend is to refresh the browser.
Comment 3 Susan McCourt CLA 2011-10-20 10:50:56 EDT 
(In reply to comment #1)
> This could have been spotted if we had bug 339848 fixed. For now, we could
> disable the Commit button until result of a previous commit has returned. A
> warning about an empty commit would also help.

if it's straightforward to detect an empty commit, a warning would reduce the noise in the repo, but this is not a big deal (post 0.3)

Mainly wanted to ensure we knew about it.  Sounds like a more substantive solution is planned (bug 339848.
Comment 4 John Arthorne CLA 2015-04-27 11:00:08 EDT 
Hasn't been seen in a long time, much of this has been rewritten since. We also have warning for empty commits now that will help if user clicks commit twice.