Community
Participate
Working Groups
somewhere along the line, we've lost the "insert edit field next to new command" behavior and instead we are getting window.prompt for new file and folder names. Bummer. I don't see a change in fileCommands, so I suspect the dom id changed (perhaps command framework changes?) and therefore it defaults to the window.prompt because it can't figure out where to insert the box.
I'd like to look at this for RC3 because I think it's a recent regression.
this was working in v20111004-2009, and broken in v20111004-2139
This was broken by some sloppy cut and paste in my sprite refactoring. As part of that code, I only create an image element for a command if it's needed (before we always had one, even an empty one, for text links). When moving that code around, I accidentally put the setting of the link id in the conditional part where the image code goes. This means that text link commands (such as most toolbar commands) no longer had their id assigned to the link, which in turn meant there was no id being passed to the handler, and therefore the code that looked up a dom id to decide where to put the edit box couldn't find anything. Moved the id code back outside of the conditional. Adding mark for review.
Adding Simon for approval. Assuming Mark approves it, are you okay? this is a regression introduced in RC1 and it's a one liner to fix it.
+1 from me Tested various ways to launch commands and they all worked.
pushed to master.
