Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 361434 - For statement fixes
Summary: For statement fixes
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P1 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-19 12:57 EDT by Scott Greer CLA
Modified: 2017-02-23 14:17 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Greer CLA 2011-10-19 12:57:23 EDT 
Jeff has reworked the For statement and related templates to address the following bugs:  361155, 361163, 360416;  this bug is to cover the work required to "port" that work to JS gen.

It encompasses looking at the following parts in Java gen and mirroring the logic in their JS gen counterparts:

* org.eclipse.edt.gen.java.templates
  * ForStatementTemplate.java
  * ExitStatementTemplate.java

and possibly the following templates:
  * Label.java
  * ContinueStatementTemplate

Unit- and regression-testing should probably rely the testcases in  org.eclipse.edt.tests.javascript/EGLSource/FVT/baseStatements AND/OR org.eclipse.edt.eunit.test/EGLSource/FVT/baseStatements
Comment 1 Justin Spadea CLA 2011-10-20 12:33:58 EDT 
Merged the changes from ForStatementTemplate and ExitStatementTemplate to jsgen.
Comment 2 Lisa Lasher CLA 2011-11-02 10:25:06 EDT 
closing this defect