Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 361411 - Add RUIPropertiesLibrary to New Library wizard
Summary: Add RUIPropertiesLibrary to New Library wizard
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Zhi Zhu CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-19 10:38 EDT by Justin Spadea CLA
Modified: 2017-02-23 14:18 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Spadea CLA 2011-10-19 10:38:22 EDT
It should be like the other wizards where it's template based. See New Handler wizard for how users can pick from the available templates.

Not critical for 0.7.0.
Comment 1 Zhi Zhu CLA 2011-10-20 20:32:09 EDT
fix it
Comment 2 Brian Svihovec CLA 2011-10-24 09:58:03 EDT
Should we be altering the contents of the 'new library' wizard depending on the type of project that is selected when the new wizard is invoked?  It appears that the current implementation will only show the RUIPropertiesLibrary if the project is a 'RUI project'.  I am thinking that we should show the option all of the time, since a user may want to create a 'basic' project that contains libraries, and this wizard would not show in that scenario.  I am cc'ing Theresa for guidance.

Also, the check for 'isRUIProject' does not seem entirely correct.  As I mentioned above, a user may create a Basic project that is configured for JavaScript generation, but the RUIPropertiesLibrary option would not appear in the new Library wizard because this project does not reference the widget projects.

In general, I think we should go with the easy solution and show the library all of the time, and remove the 'isRUIProject' check.
Comment 3 Zhi Zhu CLA 2011-10-25 20:45:31 EDT
Based on Brian's comment, change its behavior, now basic project can also see the option for creating RUIPropertiesLibrary. But for its specific contents, please offer more feedback
Comment 4 Brian Svihovec CLA 2011-10-25 22:04:50 EDT
Can you elaborate on what you mean by 'its specific contents'?  I think showing the RUIPropertiesLibrary radio button all of the time is fine.
Comment 5 Zhi Zhu CLA 2011-10-25 22:10:35 EDT
If showingthe RUIPropertiesLibrary radio button all of the time is fine, then the work is done.

  What I mean whether we should generate different library content for diffent project type.
Comment 6 Brian Svihovec CLA 2011-10-25 22:15:56 EDT
I think the content should be the same in all projects, so we should be done for now.  Theresa can comment if she things otherwise.
Comment 7 Justin Spadea CLA 2011-10-26 09:05:26 EDT
Should we rename RUIPropertiesLibrary to NLSPropertiesLibrary so that it won't be so confusing if another generator chooses to support it?
Comment 8 Brian Svihovec CLA 2011-10-26 09:20:49 EDT
The RUIPropertiesLibrary stereotype is in the eglx.ui.rui package, so I think it is ok if we leave it with this name for now.  In the future, if we decide that the same approach can be used for NLS in various types of applications, this can be renamed and moved to a more 'core' package.
Comment 9 Zhi Zhu CLA 2011-10-31 04:13:20 EDT
close it