Comment 1 Dani Megert 2011-10-19 10:16:56 EDT

Created attachment 205530 [details]
Fix

Comment 2 Dani Megert 2011-10-20 10:56:06 EDT

Fixed in master: a5b3f92ac7a9e31376dbcd6ee08c22715f55b8ed

Comment 3 Ayushman Jain 2011-10-25 06:08:13 EDT

IMHO, The wording in the UI does not exactly capture what the new warning is meant for. The configuration says "Output location overlaps source location". 

This makes it look like its a configuration to raise an error for the following setup

P
+src 
 output folder: src

However, it is actually for a scenario where another source folder is using src as its output folder i.e

P
+src 
 output folder: src
+src2
 output folder: src

Comment 4 Dani Megert 2011-10-25 06:32:32 EDT

> P
> +src 
>  output folder: src
This is the special case where it works.

What would you suggest then?

Comment 5 Ayushman Jain 2011-10-25 06:41:14 EDT

(In reply to comment #4)
> What would you suggest then?
"Output location overlaps distinct source location"
This would bring it closer to the error message and would eliminate the above case. (Well, I know that the 'distinct' things here are the source folders, but I don't think we can capture the proper semantics of distinct in a short message. This message will atleast prevent the user from jumping to conclude that this is related to same folder case in comment 3)

Comment 6 Dani Megert 2011-10-25 06:45:00 EDT

(In reply to comment #5)
> (In reply to comment #4)
> > What would you suggest then?
> "Output location overlaps distinct source location"

> This message will atleast prevent the user from jumping to conclude
> that this is related to same folder case in comment 3)
I think "distinct" even tells less. And in some way the folders don't overlap if there's just one source folder as output folder since there won't be conflicts.

Comment 7 Dani Megert 2011-10-26 01:58:23 EDT

Verified in I20111025-1800.