Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 361370 - Refactoring in AbstractAcceleoGenerator whether running in eclipse
Summary: Refactoring in AbstractAcceleoGenerator whether running in eclipse
Status: CLOSED FIXED
Alias: None
Product: Acceleo
Classification: Modeling
Component: Core (show other bugs)
Version: 3.1.1   Edit
Hardware: PC All
: P3 enhancement
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-19 06:21 EDT by Rainer Menke CLA
Modified: 2015-05-27 08:58 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rainer Menke CLA 2011-10-19 06:21:38 EDT
Build Identifier: 3.1.2.v20111005-0955

In the class AbstractAcceleoGenerator the method 

public void initialize(EObject element, File folder, List<? extends Object> arguments) throws IOException {

calls the operation 

resourceSet.setURIConverter(createURIConverter()); 

if the condition

EMFPlugin.IS_ECLIPSE_RUNNING

is fulfilled. Because it is possible to require different behaviour in different runtimes ( eclipse, osgi, plain java, apache ant ) each generator has to override the initialize method of the abstract generator. Based on this fact, it would be a good idea, to move the condition into the implementation of

protected URIConverter createURIConverter()

of the class AbstractAcceleoGenerator.

Reproducible: Always
Comment 1 Stephane Begaudeau CLA 2012-02-16 09:19:12 EST
A fix has been contributed on HEAD and R3_2_maintenance. It will be available in Acceleo 3.2.1 and 3.3.0
Comment 2 Stephane Begaudeau CLA 2012-02-16 09:22:41 EST
Marking as resolved.
Comment 3 Laurent Goubet CLA 2015-05-27 08:58:03 EDT
Closing resolved bugs