Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 361365 - 401 html error page images don't load
Summary: 401 html error page images don't load
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Server (show other bugs)
Version: 0.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 0.3 RC3   Edit
Assignee: Malgorzata Janczarska CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-19 06:10 EDT by Malgorzata Janczarska CLA
Modified: 2011-10-20 05:23 EDT (History)
2 users (show)

See Also:
tomasz.zarna: review+
simon_kaegi: review+

Attachments
fix (4.75 KB, patch)
2011-10-19 08:27 EDT, Malgorzata Janczarska CLA 		no flags Details | Diff
fix (4.81 KB, patch)
2011-10-19 09:04 EDT, Malgorzata Janczarska CLA 		no flags Details | Diff
fix (4.81 KB, patch)
2011-10-19 11:25 EDT, Malgorzata Janczarska CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Malgorzata Janczarska CLA 2011-10-19 06:10:53 EDT 
After changing images paths to relative they stopped displaying on the HTML 401 pages, because 401 page is displayed under current URL. The solution would be to redirect user to the 401 page instead of displaying it under current URL.
Comment 1 Malgorzata Janczarska CLA 2011-10-19 08:27:20 EDT 
Created attachment 205516 [details]
fix

This is tested fix for this issue. 
I hope for +1 to merge it to master.
Comment 2 Malgorzata Janczarska CLA 2011-10-19 09:04:03 EDT 
Created attachment 205522 [details]
fix

Very nice, I've been redirecting to absolute path.
Comment 3 Tomasz Zarna CLA 2011-10-19 10:01:30 EDT 
I saw the broken prompt and I saw it fixed with Gosia's latest patch. +1 from me.
Comment 4 Simon Kaegi CLA 2011-10-19 11:13:36 EDT 
You use getRequestURL in one place and the getRequestURI in the other. Probably should be one or the other (suspect getRequestURL).
Comment 5 Malgorzata Janczarska CLA 2011-10-19 11:25:58 EDT 
Created attachment 205542 [details]
fix
Comment 6 Malgorzata Janczarska CLA 2011-10-19 11:26:56 EDT 
(In reply to comment #4)
> You use getRequestURL in one place and the getRequestURI in the other. Probably
> should be one or the other (suspect getRequestURL).
corrected.
Comment 7 Simon Kaegi CLA 2011-10-19 11:59:17 EDT 
Go for it.
Comment 8 Malgorzata Janczarska CLA 2011-10-20 05:23:47 EDT 
(In reply to comment #7)
> Go for it.
Pushed