Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 361338 - ant.tests.core: NPE in OptionTests.testSpecifyBadTargetAsArg
Summary: ant.tests.core: NPE in OptionTests.testSpecifyBadTargetAsArg
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Ant (show other bugs)
Version: 3.8   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.6.2+   Edit
Assignee: Satyam Kandula CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-19 02:47 EDT by Dani Megert CLA
Modified: 2011-11-22 09:46 EST (History)
1 user (show)

See Also:

Attachments
Proposed patch (2.96 KB, patch)
2011-10-19 06:16 EDT, Satyam Kandula CLA 		satyam.kandula: review?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2011-10-19 02:47:16 EDT 
3.6.2+J7.

java.lang.NullPointerException
at org.eclipse.ant.tests.core.tests.OptionTests.testSpecifyBadTargetAsArg(OptionTests.java:297)
at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:376)
at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:209)
at org.eclipse.test.CoreTestApplication.runTests(CoreTestApplication.java:35)
at org.eclipse.test.CoreTestApplication.run(CoreTestApplication.java:31)
at org.eclipse.equinox.internal.app.EclipseAppContainer.callMethodWithException(EclipseAppContainer.java:587)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:198)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:369)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:620)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:575)
at org.eclipse.equinox.launcher.Main.run(Main.java:1408)
at org.eclipse.equinox.launcher.Main.main(Main.java:1384)
at org.eclipse.core.launcher.Main.main(Main.java:34)
Comment 1 Satyam Kandula CLA 2011-10-19 04:34:45 EDT 
My mistake: As part of 355614, I have the code change but didn't modify the test that breaks. Will add a patch shortly.
Comment 2 Dani Megert CLA 2011-10-19 04:44:14 EDT 
Satyam, this also need to go into the Java 7 backport.
Comment 3 Satyam Kandula CLA 2011-10-19 06:16:43 EDT 
Created attachment 205491 [details]
Proposed patch

This patch has the required test change as well as the new test. Updated the Manifest.Mf file also.
Comment 4 Satyam Kandula CLA 2011-10-19 06:19:33 EDT 
(In reply to comment #2)
> Satyam, this also need to go into the Java 7 backport.
Dani, There is no separate branch for Ant for Java 7. Is updating the tag and requesting for a new build good enough?
Comment 5 Dani Megert CLA 2011-10-19 06:59:48 EDT 
(In reply to comment #4)
> (In reply to comment #2)
> > Satyam, this also need to go into the Java 7 backport.
> Dani, There is no separate branch for Ant for Java 7.
There is a separate branch for the map file, hence you need to update both branches (at least the map file in the org.eclipse.releng project).

> Is updating the tag and requesting for a new build good enough?
We don't rebuild the normal 3.6.2+ build just because of test failures.
Comment 6 Dani Megert CLA 2011-10-22 01:49:43 EDT 
Satyam, this should have gone into the 3.6.2+J7 work this week. Please make sure that it gets fixed in 3.6.2+ and that the 3.6.2+ and 3.6.2+J7 map files get updated. No need for a rebuild. Thanks.
Comment 7 Michael Rennie CLA 2011-10-27 11:35:08 EDT 
(In reply to comment #6)
> Satyam, this should have gone into the 3.6.2+J7 work this week. Please make
> sure that it gets fixed in 3.6.2+ and that the 3.6.2+ and 3.6.2+J7 map files
> get updated. No need for a rebuild. Thanks.

I think Satyam is off this week. I pushed the patch to 3.6.2+ and tagged it as v20111027-0927_r363 in both 3.6.2+ and 3.6.2+Java7.