Community
Participate
Working Groups
Build Identifier: Common file operations should be considered in the file system of Target Explorer: 1. Delete a file. 2. Rename a file to another name. 3. Move a file from one folder to another. 4. Cut, copy and paste a file. etc. Reproducible: Always
Created attachment 205972 [details] A proposed design document for the extended file operations. Hi Uwe, This is a proposed design document for this enhancement request. Please have a review and provide feedback. Thanks a lot! -William
Created attachment 206103 [details] A proposed design document for the extended file operations--Rev 1 The enablement of delete action seems not right in the first version. Add two constraints: The selected files/folders should not include root directory folders. The selected files/folders should be located at a same level of a same directory. They should be siblings instead of parents and children.
Hi Uwe, I have uploaded a revision of the proposed design document with the above changes in the comment of the attachment. Please have a review. Thanks. -William
Hi William 2 Cut, Copy, Paste: - I think we should not clear the clipboard after the operation is done. In Windows explorer, you can copy a file and paste it as many times you like. The only consideration should be how to make the name unique, in example by appending “(<n>)” and/or let the user confirm/choose the new name. - In the block for “Copy” you refer to “Cut” in the second sentence. - For “Cut”/”Delete” … as I mentioned in one of the meetings, the enablement depends on the remote file system type. On Unix file systems, a user can delete a file if he has write permissions to the parent folder. On Windows file systems, the user needs to have write permissions to the file itself. - For the “Paste” enablement, 2. and 3. are implicit by 1.. You won’t have a copy or cut operation in the clipboard of 2. and 3. are false. They are precondition of the operation to get in the clipboard. - Menu layout: Is OK, but make sure you contribute Cut/Copy/Paste to “group.edit” and delete to “group.delete”. 3 Delete Files - How will the delete confirmation dialog looks like in case of multi file/folder selection? 5 Move Files - The drag/drop operations are not exclusive to “move”. In fact the DnD operations have to be equivalent to the Copy/Cut + Paste actions. - The difference of “Move” to “Cut/Paste” should be that of navigating to the destination folder in the tree, a dialog opens showing the tree and the user does navigate to the destination in the dialog. See the “move” operation of a Java file in the package explorer (Context Menu > Refactor > Move). Cheers, Uwe
Created attachment 206186 [details] A proposed design document for the extended file operations--Rev 2 Hi Uwe, I have revised the proposal according to your feedbacks. About "Move Files", the previous version does not mandate DnD and the menu invocation are exclusive. They are meant to coexist with each other. End users can use either way to move files/folders he/she selects. And these two operations are also designed equivalent to the action combination of Cut/Copy + Paste. It was not clear to be understood. I have made it clear in this revision. The menu "Move" is designed as you mentioned in the feedback which similar to that of Java Refactoring in the package explorer. The user will be prompted to select a destination folder in a file dialog before moving. -William
Comment on attachment 206103 [details] A proposed design document for the extended file operations--Rev 1 Deprecated by the newer version.
Created attachment 207344 [details] A proposed design document for the extended file operations--Rev 3 Some revision to the enablement of cut/move/DnD parts.
Committed the fix at: http://git.eclipse.org/c/tcf/org.eclipse.tcf.git/commit/?h=juno-refactoring&id=3dcc9f514f1a79d197ed1f0083299cd9a83aaad9
