Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 361281 - JpaFacetActionPage leaks IFacetedProjectListener (never removed)
Summary: JpaFacetActionPage leaks IFacetedProjectListener (never removed)
Status: RESOLVED FIXED
Alias: None
Product: Dali JPA Tools
Classification: WebTools
Component: JPA (show other bugs)
Version: 2.3.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.0.2   Edit
Assignee: Karen Butzke CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-18 13:28 EDT by Kevan Holdaway CLA
Modified: 2012-01-04 10:19 EST (History)
3 users (show)

See Also:
neil.hauge: review+

Attachments
proposed patch against 3.0 maintenance (2.42 KB, patch)
2011-10-31 13:07 EDT, Karen Butzke CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevan Holdaway CLA 2011-10-18 13:28:56 EDT 
Build Identifier: Version: 2.3.4.v201104192310-7N7UF77FD3wTgcVbmmf0cT Build id: 20100915173744

org.eclipse.jpt.ui.internal.wizards.JpaFacetActionPage.setUpRuntimeListener() adds a IFacetedProjectListener to the IFacetedProjectWorkingCopy but never removes it.

This causes the listener to be active even when the JPA facet has been removed.

  

Reproducible: Always

Steps to Reproduce:
1. In web project creation, add the JPA facet
2. Remove it again (but notice the JpaFacetActionPage is still a listener because it never removed itself in the dispose method.
3.
Comment 1 Karen Butzke CLA 2011-10-31 13:06:46 EDT 
fixed in HEAD
Comment 2 Karen Butzke CLA 2011-10-31 13:07:10 EDT 
Created attachment 206227 [details]
proposed patch against 3.0 maintenance
Comment 3 Karen Butzke CLA 2011-10-31 13:20:16 EDT 
fixed in 3.0 maintenance
Comment 4 Jolene Moffitt CLA 2012-01-03 14:06:44 EST 
Verified in Build M-3.3.2-20111228194624

Verified when you remove the JPA facet from the Web Project the JPA Facet page does not appear until you add the JPA facet back.  See the link to view test
steps for verification. http://wiki.eclipse.org/Dali_3.0.2
Comment 5 Kevan Holdaway CLA 2012-01-03 14:19:06 EST 
I am not sure how comment 4 would actually verify the bug is fixed.  The facet page never had issues showing up when it shouldn't have.
Comment 6 Jolene Moffitt CLA 2012-01-04 10:19:34 EST 
It was my misunderstanding, so I will convert status back to Resolved verses Verified.  When I removed the JPA facet and then added it back via the properties dialog I was receiving listener errors in the Error dialog in a build from 20111020 and when I compared this to a more recent build the listener errors were not occuring.  Sorry for the confusion.  If you would like me to verify the issue please let me know more details on how to recreate the problem so I can tell if the JpaFacetActionPage in no longer a listener.