Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 361216 - Implement org.eclipse.xtext.linking.impl.DefaultLinkingService.registerImportedNamesAdapter using an interface instead of an abstract class
Summary: Implement org.eclipse.xtext.linking.impl.DefaultLinkingService.registerImport...
Status: RESOLVED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 2.1.0   Edit
Hardware: PC All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard: v2.14
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-18 04:21 EDT by Mark Christiaens CLA
Modified: 2018-03-21 14:14 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Christiaens CLA 2011-10-18 04:21:28 EDT 
Build Identifier: 20110916-0149

org.eclipse.xtext.linking.impl.DefaultLinkingService.registerImportedNamesAdapter checks whether scopeProvider is a AbstractGlobalScopeDelegatingScopeProvider.  This is a bit uncomfortable.  When implementing your own scope provider, you do not want to derive from the above abstract class.  However, when you do not derive from this class, then the imported names functionality is broken.

Please introduce an interface that indicates that the scope can be wrapped to intercept scope requests.  

Reproducible: Always
Comment 1 Eclipse Genie CLA 2018-03-21 12:18:56 EDT 
GitHub Pull Request 663 created by [szarnekow]
https://github.com/eclipse/xtext-core/pull/663
From: genie@eclipse.org
Subject: [Bug 361216]

@id = 361216
@see_also = https://github.com/eclipse/xtext-extras/pull/240

GitHub Pull Request 240 created by [szarnekow]
https://github.com/eclipse/xtext-extras/pull/240
Comment 2 Christian Dietrich CLA 2018-03-21 14:14:48 EDT 
fixed in 2.14