Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 361199 - rname string{@Property} is not treated as annotation
Summary: rname string{@Property} is not treated as annotation
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Paul Harmon CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-17 23:14 EDT by Zhi Zhu CLA
Modified: 2017-02-23 14:14 EST (History)
1 user (show)

See Also:

Attachments
Patch for annotation indexing/search (2.21 KB, patch)
2011-11-07 16:13 EST, Paul Harmon CLA 		lasher: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zhi Zhu CLA 2011-10-17 23:14:40 EDT 
As for field annotation, whether the following format are identical:

   rname string{@Property};
   rname string{@Property{}};

   From SourceElementParser.handlePropertyBlock, it seems they are different,
it treats the second case add valid annotation, but not for first case.
Comment 1 Paul Harmon CLA 2011-11-07 16:12:49 EST 
I looked into this to make sure it wasnt an AST problem. I think I found why this is failing (I assume that annotation search is failing to find the reference to Property when it doesnt have curly braces after it).

Attached is a patch for SourceElementParser and MatchVisitor, that seem to fix the problem.

Could someone in IDE please review the changes and release them if they look reasonable?
Comment 2 Paul Harmon CLA 2011-11-07 16:13:36 EST 
Created attachment 206551 [details]
Patch for annotation indexing/search
Comment 3 Zhi Zhu CLA 2011-11-07 19:56:26 EST 
Paul, it solved the problem, I have checked in the code, thanks
Comment 4 Zhi Zhu CLA 2011-11-13 19:36:27 EST 
Verify and close it