Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 361148 - Backport Incorrect value for Service-Component header when bundle has a custom root
Summary: Backport Incorrect value for Service-Component header when bundle has a custo...
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 3.7.2   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard: NGPBUG-1181
Keywords:
Depends on: 353484
Blocks:
  Show dependency tree
 
Reported: 2011-10-17 10:32 EDT by Curtis Windatt CLA
Modified: 2011-12-13 14:47 EST (History)
4 users (show)

See Also:
curtis.windatt.public: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis Windatt CLA 2011-10-17 10:32:31 EDT 
+++ This bug was initially created as a clone of Bug #353484 +++

Cloned to backport to 3.8.2.

Steps to reproduce:
1. Create a new OSGi Bundle/Plug-in project with Bundle Root that is different from the Project Root. For example, create a new Web Application Bundle (WAB) project: http://wiki.eclipse.org/Libra/Getting_Started#Create_new_Web_Application_Bundle. In this case the Bundle Root is the /WebContent folder.
2. Create an OSGI-INF folder under the Bundle Root folder. In the case of WAB example /WebContent/OSGI-INF. 
3. Call the New Component Definition wizard and create a new component.xml under the OSGI-INF folder.

The component.xml is correctly created, but the MANIFEST.MF is incorrectly modified. The Service-Component header points to the component.xml, but the path is relative the Project Root instead of to the Bundle Root. 

In the WAB example, it looks like:

  Service-Component: WebContent/OSGI-INF/component.xml

while it should look like:

  Service-Component: OSGI-INF/component.xml
Comment 1 Curtis Windatt CLA 2011-10-17 10:33:14 EDT 
That should read, cloned to backport to 3.7.2
Comment 2 Kaloyan Raev CLA 2011-10-26 10:49:37 EDT 
Curtis, I'd like to check if this change went in the 3.7 stream?
It looks like a small change in the master branch, so just a simple cherry-pick to 3.7 maintenance should be sufficient, doesn't it?
Comment 3 Curtis Windatt CLA 2011-10-26 10:55:46 EDT 
(In reply to comment #2)
> Curtis, I'd like to check if this change went in the 3.7 stream?
> It looks like a small change in the master branch, so just a simple cherry-pick
> to 3.7 maintenance should be sufficient, doesn't it?

The fix hasn't been backported yet.  When I do this I will close this bug as fixed.
Comment 4 Curtis Windatt CLA 2011-12-13 14:47:23 EST 
+1 for 3.7.2 as component lead

Cherry picked the commit into R3_7_maintenance

http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?h=R3_7_maintenance&id=9b39bf73f90e16fcc55fdcb4d184414bb6285838