Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 361144 - Integrate with OSGi JNDI
Summary: Integrate with OSGi JNDI
Status: CLOSED FIXED
Alias: None
Product: Gemini.Web
Classification: RT
Component: unknown (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 2.1.0.M01   Edit
Assignee: Violeta Georgieva CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 328174
Blocks: 361173
  Show dependency tree
 
Reported: 2011-10-17 10:26 EDT by Violeta Georgieva CLA
Modified: 2011-10-31 14:00 EDT (History)
1 user (show)

See Also:

Attachments
Patch proposal (18.41 KB, patch)
2011-10-18 02:56 EDT, Violeta Georgieva CLA 		glyn.normington: review+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Violeta Georgieva CLA 2011-10-17 10:26:12 EDT 
According to specification, Gemini Web has to register the following services:
- Initial Context Factory Builder
- Object Factory Builder
- URL Context Provider
Comment 1 Glyn Normington CLA 2011-10-17 10:34:01 EDT 
Is it a requirement that Gemini Web does not have a hard dependency on OSGi JNDI or Gemini Naming? I think it should be.
Comment 2 Violeta Georgieva CLA 2011-10-17 10:43:23 EDT 
(In reply to comment #1)
> Is it a requirement that Gemini Web does not have a hard dependency on OSGi
> JNDI or Gemini Naming? I think it should be.

It will not depend neither on OSGi JNDI nor on Gemini Naming.

GW will expose services with the corresponding interfaces:
- javax.naming.spi.InitialContextFactoryBuilder
- javax.naming.spi.ObjectFactoryBuilder
- javax.naming.spi.ObjectFactory

Patch will be attached so we can comment on it.
Comment 3 Glyn Normington CLA 2011-10-17 10:45:51 EDT 
Perfect. Thanks.
Comment 4 Violeta Georgieva CLA 2011-10-18 02:56:46 EDT 
Created attachment 205386 [details]
Patch proposal

The interesting part is:

         if (OSGI_NAMING_ENABLED.equals(useNaming)) {
-            //TODO Integration with OSGi JNDI will be covered in
-            //https://bugs.eclipse.org/bugs/show_bug.cgi?id=361144
+            registerInitialContextFactory();
+            registerJavaURLContextFactory();
+            registerObjectFactoryBuilder();
         }
Comment 5 Glyn Normington CLA 2011-10-18 05:51:04 EDT 
Comment on attachment 205386 [details]
Patch proposal

Looks ok to me.
Comment 6 Violeta Georgieva CLA 2011-10-18 08:36:30 EDT 
Change is tested, committed and pushed.
Commit ID: 683e8e18b2464fb429fbf4f96cef4660177ee273