Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 361109 - [client][log] Add icon for the Cherry-pick action
Summary: [client][log] Add icon for the Cherry-pick action
Status: CLOSED DUPLICATE of bug 364399
Alias: None
Product: Orion
Classification: ECD
Component: Git (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 0.4   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 360986
Blocks:
  Show dependency tree
 
Reported: 2011-10-17 05:06 EDT by Tomasz Zarna CLA
Modified: 2011-12-16 12:41 EST (History)
4 users (show)

See Also:


Attachments
New icon (101 bytes, image/gif)
2011-10-19 06:02 EDT, Tomasz Zarna CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2011-10-17 05:06:31 EDT
Each time I'm seeing actions on the Git Log I fell under impression that the Tag icon and the Cherry-pick link are actually a single action. That's only for a split second, but I still think it would be better if we had an icon for the Cherry-pick action.
Comment 1 Tomasz Zarna CLA 2011-10-19 06:02:13 EDT
Created attachment 205487 [details]
New icon

Tada! Susan what do you think? Please, be careful with your words, you'll be commenting on a young artist's work :)

Seriously, any chance for this kind of change in .3?
Comment 2 Malgorzata Janczarska CLA 2011-10-19 06:18:42 EDT
Tomek, lovely cherry, but I think the stalks of your cherries should meet just under the leaf, like this:
http://breh.myncblogs.com/files/2011/02/cherries.jpg
without this branch where is comes from. It's more cherry-like ;)
Comment 3 Susan McCourt CLA 2011-10-19 11:44:21 EDT
(In reply to comment #1)
> Created attachment 205487 [details]
> New icon
> 
> Tada! Susan what do you think? Please, be careful with your words, you'll be
> commenting on a young artist's work :)

I appreciate the effort and enthusiasm!!
but...I don't think I would know what that icon meant without hovering on the tooltip.
> 
> Seriously, any chance for this kind of change in .3?

I agree that the mix of icons and text is very random.  But we're having doubts in general about the icons (See also bug 360964, where the discussion is about either getting rid of icons in favor of button/text things, or at least improving the visuals around the icons to make it clear that they are a button.)

So I'm inclined to live with the randomness and tackle the icon problem before deciding we turn text into icons.
Comment 4 Szymon Brandys CLA 2011-12-12 06:23:36 EST
Susan, once you decide what the styling is, could you also update the icon or if we don't need the icon, just close the bug?
Comment 5 Susan McCourt CLA 2011-12-16 12:40:51 EST
Had a review session with Linda about all the command stuff, and she is suggesting we use text on the toolbar and icons everywhere else, and then try to be very selective about which commands appear in the actions column vs. a secondary menu, so that we don't have lots of icons for people to remember.

So...we will get an icon for cherry pick (will add to bug 364399).  Will give Tomek's icon to the designer as a starting point...
Comment 6 Susan McCourt CLA 2011-12-16 12:41:28 EST

*** This bug has been marked as a duplicate of bug 364399 ***