Community
Participate
Working Groups
0.3 RC2 I have a git repository with two configured remotes: "origin" and "heroku". My current active branch is using "heroku" remote. When I go to the git status page, it still says "origin/master" at the top of the remote log pane. However, from looking at the log it seems to be showing the correct thing ("heroku/master"). So it looks like the label is wrong. In fact there is no indication on this page of what remote I am using. Maybe that information should be in the title area at the top as well.
Created attachment 205234 [details] Screen shot In this screenshot my mouse is hovering over the "Complete log" link. You can see that the title says origin/master but the link is pointing to heroku/master.
This might seem trivial but this wrong information could cause someone to be blissfully pushing to the wrong remote without realizing it, so marking "major".
(In reply to comment #2) > This might seem trivial but this wrong information could cause someone to be > blissfully pushing to the wrong remote without realizing it, so marking > "major". Investigating and try to fix in RC3.
Worthwhile, but still need someone to review the actual code change when ready.
(In reply to comment #4) > Worthwhile, but still need someone to review the actual code change when ready. Found the reason: The remote info has two children in this case.And the second child is the current remote. As the children do not have "current" flag , we are always using the first child as current, which is dangerous. We should use this._curBranch.RemoteLocation[0].Name instead of this._remoteInfo.Children[0].Name. Also we should use remote name + branch name in the title bar as John suggested. I have a fix now, will polish it and ask Mark to review.
Created attachment 205353 [details] Fix patch for review Mark, I've created the patch for you to review. Thanks.
+1 from me
fixed with 3c4e12deff75ab1ce4ce47e634c6b20910e75fb5.
