Community
Participate
Working Groups
Created attachment 205220 [details] screenshot with empty tooltip, no user Orion 0.3RC2 I was testing in firefox and things were progressing nicely. I reloaded a page, saw some timeouts in the console and my navigator page didn't show up. So I reloaded again. This time, my navigator came up, but it had no contents. I panicked, thinking my workspace was toast, but then noticed that I was not logged in anymore. I was in the broken state previously reported on the mailing list, where you get the empty tooltip and no way to log in.
There was seemingly no way to get out of this state, so I decided to check my plugin list. Indeed, the file service and authentication plugins were no longer working. See screenshot. Several things seem wrong here. 1) if we can't find authentication/file service plugins to populate the tooltip, we should at least describe the problem and provide a link to the plugins page? 2) in other places where we are trying to talk to a plugin to get something done (like populate the navigator) and we can't find the plugin, we should report it somewhere.
Created attachment 205222 [details] screenshot of plugins with problems
I believe I saw Ken get into this state yesterday running on latest code. Neither "Sign in" nor "Sign out" appeared as options in the user menu.
(In reply to comment #3) > I believe I saw Ken get into this state yesterday running on latest code. > Neither "Sign in" nor "Sign out" appeared as options in the user menu. Did he also had authenticationPlugin not loaded?
I've gotten into this state on and off since reporting the bug and a reload of all plugins fixes it, but I never am able to understand how I got in that state. It feels like a timing problem, but I can't be sure.
(In reply to comment #5) > I've gotten into this state on and off since reporting the bug and a reload of > all plugins fixes it, but I never am able to understand how I got in that state. > It feels like a timing problem, but I can't be sure. This is bad. Do you sometimes have problems like this with other plug-ins? On screenshoot I can see that fileClientPlugin is also missing. I have to say it happened a few times to me, with different plug-ins, but usually when I there where some fresh changes in plug-ins or when I was just restarting my server, or when there was a plug-in missing. Never "just like that". But I host Orion on localhost. Simon, do you have any idea why correct, existing plug-ins may occur as missing? Authentication needs a plug-in to show correctly the content of the pop-up. However 401 is handled properly without any plugin. Also when we get 401 and we are not able to match it with any plug-in, we may be using it to show some information in the popup, but if we are already logged in there is no way we may get extra information about authentication service, for instance how to log out or what is my user name or what is the name of authentication service.
(In reply to comment #6) > This is bad. Do you sometimes have problems like this with other plug-ins? I think that fileClient goes missing when auth goes missing. I've not been that methodical in figuring it out, usually I'm trying to get something done and just do the reload and move on. I work from orion.eclipse.org, so guessing about the things I do that could cause this: - changing builds and a plugin has changed - reloading plugins without clearing localStorage - I run self hosting sites all the time I'll try to update this bug from now on when it happens, maybe we would see a pattern (such as realizing that a plugin changed in a build on the day the problem happened, etc.)
Today after my local Orion server restart I noticed that 4 plug-ins including auth and file plug-ins are not loaded. I don't know what caused this, but I think we need a separate bug against our plug-ins framework. This bug is just for handling the problem correctly by the auth framework. If we find out that an auth plug-in on the list is not loaded properly, we should inform the user and point out the plug-ins page (as Susan suggested in comment 1). However if there is no auth plug-in because no-one added it to the list, we should not treat this as an error situation.
I opened a separate bug for disappearing plugins: Bug 370345, as this is much wider problem than just this case. In this case I'll see what can be done to gracefully handle situation when there are no authentication puglins but we got authenticated based on authentication information provided in the 401 response.
I can see why the popup was empty. When site handles 401 than the security popup is populated with result of the authentication. But when page is loaded when we are already logged in then the dialog is not populated. Unfortunately there are two problems we won't be able to solve here when authentication plugin: we can't populate the dialog informing to what services are we logged in, we can only display information that there are in authentication pending now. We also can't handle logging out, because without authentication plugin we don't know how to do it.
I made changes to mitigate this problem: * when you log it successfully after 401 the pending authentication is displayed in the list as authenticated * when there was no 401 and we can't tell if there are any services that you are logged in to, the dialog is not empty but displays "No authentication required." so that you know there is no ongoing authentication you have to perform The rest can be handled only when there is an authentication plugin. Only fixing Bug 370345 can solve this problem completely.
Marking FIXED as all I could do about the problem was done.
