Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 360955 - Tag/branch selection dialog shows "null"
Summary: Tag/branch selection dialog shows "null"
Status: VERIFIED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 1.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Kevin Sawicki CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-14 08:31 EDT by Dani Megert CLA
Modified: 2011-11-10 02:45 EST (History)
2 users (show)

See Also:

Attachments
Picture showing bug (9.78 KB, image/png)
2011-10-14 08:32 EDT, Dani Megert CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2011-10-14 08:31:30 EDT 
1.2.0.201110100910.

1. select two projects in the Package Explorer
2. context menu > Compare With > Branch, Tag or Reference...
==> dialog title has "null" in it.

Works if one only selects one project.
Comment 1 Dani Megert CLA 2011-10-14 08:32:22 EDT 
Created attachment 205189 [details]
Picture showing bug
Comment 2 Remy Suen CLA 2011-10-14 09:03:41 EDT 
Think I've seen this before also.
Comment 3 Remy Suen CLA 2011-10-21 21:45:09 EDT 
What would you suggest here, Dani? "Compare N Projects with a Branch, Tag, or Reference" or just "Compare Projects with a Branch, Tag, or Reference"?
Comment 4 Dani Megert CLA 2011-10-24 04:01:57 EDT 
(In reply to comment #3)
> Reference" or just "Compare Projects with a Branch, Tag, or Reference"?
I would put "Compare With Branch, Tag or Reference" into the dialog title (always) and delete the banner text. This just tries to duplicate the title.
Comment 5 Kevin Sawicki CLA 2011-11-07 18:50:09 EST 
Proposed fix pushed to: http://egit.eclipse.org/r/#change,4564
Comment 6 Matthias Sohn CLA 2011-11-09 18:11:25 EST 
merged as fb5a53fd8f7ff6767aaaaa94a275db52eebf71f9
Comment 7 Dani Megert CLA 2011-11-10 02:45:26 EST 
Verified in 1.2.0.201111100222.