Community
Participate
Working Groups
Build Identifier: 20110615-0604 For the remote launch case , we may deploy the valgrind plugin on the none-unix like operation system like window. But on these host ,there is no "which" command is available. The ValgrindPlugin will try to initial the default preference store with the valgrind path, and it will use the "which" command to find it. This action will cause the eclipse hangs. Reproducible: Always Steps to Reproduce: 1.install the valgrind plugin on windows host. 2.open Window -> Preferences ->valgrind 3.The eclipse hang and no response.
Created attachment 205188 [details] patch
Comment on attachment 205188 [details] patch Ryan, can you please add a legal statement here on bugzilla certifying that you wrote the patch yourself, contribute under the EPL and have the right to do so. See my legal message on bug 360085 comment 7 as a template. Without such a message by today, the Linuxtools team cannot integrate your patch into 0.9.0.
CQ:WIND00311696 I think the problem is severe because regardless of whether an end user actually plans to use valgrind or not, just by opening the Preference page all of Eclipse hangs which may cause loss of data and thus qualifies for a "critical" issue. I'm not sure if the attached patch is the best way addressing this (I'd personally avoid running the "which" command at all and use CDT's org.eclipse.cdt.utils.PathUtil#findProgramLocation(String) instead, which works on all Platforms without executing an external tool. And valgrind.core (which hosts ValgrindCommand) has a dependency onto org.eclipse.cdt.utils package already.
1. Is the Valgrind feature available on win32? 2. Francois, did this get into the IP log you submitted?
(In reply to comment #4) > 1. Is the Valgrind feature available on win32? > 2. Francois, did this get into the IP log you submitted? It's not in the IP log but it hasn't been submitted it yet (issue with the tool).
Legal Message: I, Ryan Xu, declare that I developed attached code from scratch, without referencing any 3rd party materials except material licensed under the EPL. {I am authorized by my employer to make this contribution under the EPL.}
(In reply to comment #4) > 1. Is the Valgrind feature available on win32? Today, the "org.eclipse.linuxtools.valgrind" feature.xml has this: os="linux,macosx" So it's not possible to install it on Windows using p2. But respective plugins don't have any host restriction, they can be installed on Windows using the dropins mechanism, and and they do actually work fine on Windows. So looking at upcoming "remote valgrind" scenarios, I think this should be addressed; but I'm going to change the severity from "critical" to enhancement given that win32 apparently isn't a supported platform today.
Jeff, please get this applied today. Francois, please wait to submit the IP log until Jeff has done this. Thanks to all.
Comment on attachment 205188 [details] patch Less than 250 lines.
Patch applied.
Target milestone was empty, but AFAIK this went into 0.9.0
This was committed in 0de31589c9c85cebfed0bff2a2b89a15d1106838. In the future, Jeff, please put the SHA-1 of the commit when you close bugs with contributions. Thanks.
(In reply to comment #12) > This was committed in 0de31589c9c85cebfed0bff2a2b89a15d1106838. > > In the future, Jeff, please put the SHA-1 of the commit when you close bugs > with contributions. Thanks. Will do.
