Community
Participate
Working Groups
Build Identifier: 201110130940 DnD a TextField into a handler and change its padding. The display in Design view is incorrect. But it display correctly in preview. Reproducible: Always
It works well in the latest build, please try it again.
The TextField in VE is still not displayed correctly. This should be an VE issue. Forest , Could you please have a look?
It occurs on IE 8, the firefox is fine
also occurs on RBD with IE 8
Created attachment 206381 [details] fix
It is caused by the difference of boxing model between IE and FF, fix by adding padding and border width to the whole width and height of widget in IE.
Created attachment 206390 [details] new fix
Xiao Bin, please check in the first fix, the second one has problem.
Can you describe the need for the 'isContainer' function? Is there no need to add the additional padding information for 'containers'? Will this check work for all types of 'containers', and not just our GridLayout or Box? Assuming we need 'isContainer', can we rename getOuterHeightInPixels2 and getOuterWidthInPixels2 to something more descriptive like 'getOuterHeightInPixelsNonContainer'?
Created attachment 206439 [details] fix with name refactoring
Hi, Brian IE calculate the width and height of table differently than others, so we need the function to handle different situation. I have changed "isContainer" to "isTable" and "getOuterHeightInPixels2" to "getOuterHeightInPixelsNonTable".
Created attachment 206453 [details] fix for div condition
I have did a fully test of all the widget selection in VE, and made a new fix for DIV condition.
Please remove the alerts from egl_develompent.js. I don't see the function isTable being used. Is this still needed? The function isIESpecialWidget appears to be hard coded for Box widgets and Dojo widgets. This probably will not work for users who are writing their own widgets and do not have access to this code. We may need to add something to the VEWidget annotation to resolve this issue in the future (is the 'isContainer' field of the VEWidget annotation enough?) I am reopening this defect so that we can remove the alerts and isTable function. I am defering this fix until 'future' where we can enhance the isIESpecialWidget function to cover widgets not written by the EDT team. We can leave the rest of the fix as is for .7.
have removed the alert and did some refatoring
Created attachment 207115 [details] Button with and without padding
I am not sure if the RUI Widgets's claro.css file was updated for this particular defect, but the change to the padding is affecting how Buttons are rendered. According to CVS history, the following lines were removed by Yun Feng for this fix: padding:2px 8px 5px 7px; *padding: 1px 1px 2px; _padding: 1px 1px 1px; See attached screen shot for how this affects buttons. The image on the left is a RUI Button (top) and a Dojo Button (bottom) before the padding was removed. The image on the right is a RUI Button (top) and a Dojo Button (bottom) before the padding was removed.
Created attachment 207130 [details] fix for button
Hi, Brian Only roll back the padding in CSS will cause VE selection problem, so another change in egl_developement.js also needed. I have attached the patch for you to review. Thanks
What is the 'Div' condition mentioned in comment 13? The padding in claro.css was set to the following when the project was first created: padding:2px 8px 5px 7px; *padding: 1px 0 2px; _padding: 2px 6px 3px; The latest patch has: + padding:2px 8px 5px 7px; + *padding: 1px 1px 2px; + _padding: 1px 1px 1px; With the changes being made for the 'div' condition in comment 13. Unless the 'div' condition is a big issue, we should put the padding back to the way that it was when the project was created. Also, what do the '*' and "_" values mean in the padding attribute names? I am ok with committing the change to isIESpecialWidget to only run if the browser is IE. If the patch will be changed to the padding from RBD and an update to isIESpecialWidget, it can be committed to CVS. If the padding cannot be changed back to the values used in RBD, we will need to discuss the patch again.
"*" and "_" are hack for IE 6 and 7 in CSS, the problem only occurs in IE 8, so I have change them back to the same as RBD. Condition for "div" means that the widget will render to a div. Now we hard code the widgets name as Comment 14 said, and will consider to add a new annotation to solve it in future EDT release. I have checked in the patch which will be changed to the padding from RBD and an update to isIESpecialWidget,and change to P3 for further enhancement in Comment 14.
Go ahead and open an enhancement for comment 14 and let's resolve this one.
enhancement 364435 is created for comment 14.
Please refer to enhancement https://bugs.eclipse.org/bugs/show_bug.cgi?id=364435
