Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 360872 - Remove GtkCombo and friends.
Summary: Remove GtkCombo and friends.
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.8   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.8 M4   Edit
Assignee: Alexander Kurtakov CLA
QA Contact: Silenio Quarti CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 340067 361004
  Show dependency tree
 
Reported: 2011-10-13 13:05 EDT by Alexander Kurtakov CLA
Modified: 2011-12-09 11:03 EST (History)
3 users (show)

See Also:

Attachments
The patch. (18.66 KB, text/plain)
2011-10-13 13:05 EDT, Alexander Kurtakov CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kurtakov CLA 2011-10-13 13:05:29 EDT 
Created attachment 205145 [details]
The patch.

The attached patch is removing GtkCombo and related functions which are using only for pre gtk 2.4.0 which is unsupported by latest SWT.
The patch looks way bigger than it is actually, thanks to jnigen changes which I decided to include in order to have proper git-formatted patch (appliable with git am).
Build and tested locally without any problems seen (gtk 2.24)
Comment 1 Alexander Kurtakov CLA 2011-10-13 13:06:28 EDT 
P.S. This patch reduces quite a number of deprecated issues for the gtk3 port.
Comment 2 Alexander Kurtakov CLA 2011-10-13 13:14:03 EDT 
I haven't done any formating to keep the patch easy for review.
Comment 4 Silenio Quarti CLA 2011-11-16 14:01:00 EST 
Released patch to branch:

http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=f387cedab0a11fb8c290dcad92bd0503c5f0facb

I opened bug#363956 to clean up Combo further given that there is still quite a bit of unused code in there after these changes and changes for bug#361004.
Comment 5 Silenio Quarti CLA 2011-11-16 14:01:39 EST 
Thanks Alexander.