Description Steffen Pingel 2011-10-13 12:00:49 EDT

If an invalid proxy is configured that results in null for the proxy host, FileReader.sendRetrieveRequest() silently swallows the IllegalArgumentException that is thrown by the constructor of HttpHost. The results is that calls to read() on the InputStream returned by FileReader.read() block forever. In the case of Mylyn this caused silent blocking of tests without any indication of an error (bug 360824).

It doesn't seem right that the code silently ignores Throwables:

...
			} catch (Throwable t) {
				if (exception != null)
					exception.printStackTrace();
			}
			if (checkException(uri, retryCount))
				break;

checkException simply returns true indicating that the connection request was sent.