Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 360838 - [Compatibility] Missing separator in the 'Edit' menu
Summary: [Compatibility] Missing separator in the 'Edit' menu
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 4.2 M7   Edit
Assignee: Paul Webster CLA
QA Contact: Paul Webster CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-13 10:26 EDT by Remy Suen CLA
Modified: 2012-05-01 12:48 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2011-10-13 10:26:44 EDT 
There's probably a bug for this somewhere but I can't find it right now.

Our 'Edit' menu is still not quite there yet when a Java editor has been opened. There is a separator between 'Add Task...' and 'Smart Insert Mode' that we seem to be missing.
Comment 1 Remy Suen CLA 2011-10-13 11:42:31 EDT 
The cause of this bug is similar to bug 349423. That is, two menu model elements are thought of as being identical when they are not. We have an action set from org.eclipse.ui.ide that contributes to edit/additions. This ultimately creates a menu separator with the id of 'additions' with a special MMR.GROUP_MARKER tag (see the ActionSet-related code for bug 336061).

In ContributionRecord, we find a matching separator with the 'additions' element id and think of it as our own (this is wrong). The action set's visibility is evaluated to 'false' so we turn the (incorrectly) matched 'additions' separator's visibility to 'false' also, causing the separator to not show up in the 'Edit' menu.
Comment 2 Remy Suen CLA 2011-10-14 09:20:34 EDT 
Also see bug 356503 where the extra contribution being generated is causing unexpected menu contributions to show up.
Comment 3 Remy Suen CLA 2011-10-14 11:26:44 EDT 
We're missing a separator between 'Working Sets...' and 'Show Qualified Names' in the 'Breakpoints' view's view menu. Going to see if the two causes are identical.
Comment 4 Remy Suen CLA 2011-10-14 13:35:25 EDT 
(In reply to comment #3)
> We're missing a separator between 'Working Sets...' and 'Show Qualified Names'
> in the 'Breakpoints' view's view menu.

In 3.x, we have a separator in the view menu's menu manager. In 4.x, it is a group marker. Also appears to be caused by ActionSet's contributeMenuGroup(*) method.
Comment 5 Eric Moffatt CLA 2012-04-17 13:51:17 EDT 
Looks like a candidate to be deferred (unless it gets 'auto-fixed' by something more dire...;-).
Comment 6 Paul Webster CLA 2012-04-18 08:55:00 EDT 
Fixed by bug 319704

PW
Comment 7 Curtis Windatt CLA 2012-05-01 12:48:37 EDT 
Verified in I20120430-1800
All the separators in the top level menus match between 4.2 and 3.8.