Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 360836 - Utf8Appendable throws Exception where it before added replacement chars
Summary: Utf8Appendable throws Exception where it before added replacement chars
Status: RESOLVED FIXED
Alias: None
Product: Jetty
Classification: RT
Component: other (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 7.5.x   Edit
Assignee: Greg Wilkins CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-13 10:21 EDT by Thomas Becker CLA
Modified: 2011-10-19 01:32 EDT (History)
1 user (show)

See Also:

Attachments
proposed patch (5.48 KB, patch)
2011-10-13 10:25 EDT, Thomas Becker CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Becker CLA 2011-10-13 10:21:49 EDT 
Build Identifier: 

We've discussed to roll back to replacing invalid UTF8 chars.

Reproducible: Always
Comment 1 Thomas Becker CLA 2011-10-13 10:25:13 EDT 
Created attachment 205130 [details]
proposed patch
Comment 2 Greg Wilkins CLA 2011-10-19 00:14:46 EDT 
Thanks Thomas. 

But don't forget to assign these issues to somebody to look at your patch.
Comment 3 Greg Wilkins CLA 2011-10-19 00:28:38 EDT 
Thomas,

this was not how I asked for this to be fixed.

The Utf8Appendable should still throw the exception, but we should catch and ignore it instead. 

Without the thrown exception, we will not pass all the fast fail tests, which is why we changed the Utf8Appendable in the first place!
Comment 4 Greg Wilkins CLA 2011-10-19 01:32:32 EDT 
Catch, log and then ignore the exception in decodeUtf8to