Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 360781 - [Xtend] Validation of dispatch method's visibility broken
Summary: [Xtend] Validation of dispatch method's visibility broken
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 2.1.0   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: SR2   Edit
Assignee: Jan Koehnlein CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-13 04:47 EDT by Sven Efftinge CLA
Modified: 2017-09-19 17:03 EDT (History)
2 users (show)

See Also:
sven.efftinge: indigo+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sven Efftinge CLA 2011-10-13 04:47:28 EDT
When checking for the correct visibility we treat dispatch methods from super classes differently if they don't have a corresponding Xtend Function (i.e. written in Java).
In that case the visibility is determined by the dispatching method (i.e. the one without the leading underscore). That one might not be present in which case the dispatch method from the superclass doesn't have any effect on the validation. Private methods from superclasses should of course be excluded always.
Comment 1 Jan Koehnlein CLA 2011-10-13 11:56:59 EDT
Fix pushed to MASTER.

Multiple issues have been solved:
1) Only visible methods are picked up by the synthetic dispatcher.
2) Only local methods are used to calculate the visibility of the dispatcher.
3) Raised issue level for local dispatch methods with different visibility to ERROR.
4) If the synthetic dispatcher's derived visibility hides a super class, that's an error.
Comment 2 Karsten Thoms CLA 2017-09-19 16:52:05 EDT
Closing all bugs that were set to RESOLVED before Neon.0
Comment 3 Karsten Thoms CLA 2017-09-19 17:03:23 EDT
Closing all bugs that were set to RESOLVED before Neon.0